jitsi / jicofo

JItsi COnference FOcus is a server side focus component used in Jitsi Meet conferences.
Apache License 2.0
316 stars 347 forks source link

Move the metrics update logic to jicoco. #1134

Closed bgrozev closed 7 months ago

codecov[bot] commented 8 months ago

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (e20abda) 28.57% compared to head (e8fb70d) 28.95%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/jitsi/jicofo/pull/1134/graphs/tree.svg?width=650&height=150&src=pr&token=wdwr26KPKY&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi)](https://app.codecov.io/gh/jitsi/jicofo/pull/1134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) ```diff @@ Coverage Diff @@ ## master #1134 +/- ## ============================================ + Coverage 28.57% 28.95% +0.38% - Complexity 463 470 +7 ============================================ Files 128 128 Lines 7742 7711 -31 Branches 1058 1056 -2 ============================================ + Hits 2212 2233 +21 + Misses 5263 5210 -53 - Partials 267 268 +1 ``` | [Files](https://app.codecov.io/gh/jitsi/jicofo/pull/1134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) | Coverage Δ | | |---|---|---| | [...n/kotlin/org/jitsi/jicofo/bridge/BridgeSelector.kt](https://app.codecov.io/gh/jitsi/jicofo/pull/1134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-amljb2ZvLXNlbGVjdG9yL3NyYy9tYWluL2tvdGxpbi9vcmcvaml0c2kvamljb2ZvL2JyaWRnZS9CcmlkZ2VTZWxlY3Rvci5rdA==) | `61.24% <100.00%> (ø)` | | | [...rc/main/java/org/jitsi/jicofo/rest/Statistics.java](https://app.codecov.io/gh/jitsi/jicofo/pull/1134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-amljb2ZvL3NyYy9tYWluL2phdmEvb3JnL2ppdHNpL2ppY29mby9yZXN0L1N0YXRpc3RpY3MuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...o/src/main/kotlin/org/jitsi/jicofo/FocusManager.kt](https://app.codecov.io/gh/jitsi/jicofo/pull/1134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-amljb2ZvL3NyYy9tYWluL2tvdGxpbi9vcmcvaml0c2kvamljb2ZvL0ZvY3VzTWFuYWdlci5rdA==) | `48.35% <0.00%> (+6.04%)` | :arrow_up: | | [.../main/kotlin/org/jitsi/jicofo/xmpp/XmppServices.kt](https://app.codecov.io/gh/jitsi/jicofo/pull/1134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-amljb2ZvL3NyYy9tYWluL2tvdGxpbi9vcmcvaml0c2kvamljb2ZvL3htcHAvWG1wcFNlcnZpY2VzLmt0) | `0.00% <0.00%> (ø)` | | | [...org/jitsi/jicofo/metrics/JicofoMetricsContainer.kt](https://app.codecov.io/gh/jitsi/jicofo/pull/1134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-amljb2ZvLWNvbW1vbi9zcmMvbWFpbi9rb3RsaW4vb3JnL2ppdHNpL2ppY29mby9tZXRyaWNzL0ppY29mb01ldHJpY3NDb250YWluZXIua3Q=) | `0.00% <0.00%> (ø)` | | | [...src/main/kotlin/org/jitsi/jicofo/JicofoServices.kt](https://app.codecov.io/gh/jitsi/jicofo/pull/1134?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-amljb2ZvL3NyYy9tYWluL2tvdGxpbi9vcmcvaml0c2kvamljb2ZvL0ppY29mb1NlcnZpY2VzLmt0) | `3.75% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/jitsi/jicofo/pull/1134/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jitsi/jicofo/pull/1134?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jitsi/jicofo/pull/1134?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi). Last update [e20abda...e8fb70d](https://app.codecov.io/gh/jitsi/jicofo/pull/1134?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi).