jitsi / jicofo

JItsi COnference FOcus is a server side focus component used in Jitsi Meet conferences.
Apache License 2.0
314 stars 350 forks source link

Monitor visitors' codec lists, and aggregate them into a conference property. #1137

Closed JonathanLennox closed 5 months ago

JonathanLennox commented 5 months ago

Depends on https://github.com/jitsi/jitsi-xmpp-extensions/pull/104.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 54.09836% with 56 lines in your changes are missing coverage. Please review.

Project coverage is 29.41%. Comparing base (be8a115) to head (c48563d).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/jitsi/jicofo/pull/1137/graphs/tree.svg?width=650&height=150&src=pr&token=wdwr26KPKY&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi)](https://app.codecov.io/gh/jitsi/jicofo/pull/1137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) ```diff @@ Coverage Diff @@ ## master #1137 +/- ## ============================================ + Coverage 28.73% 29.41% +0.68% - Complexity 467 485 +18 ============================================ Files 129 130 +1 Lines 7747 7863 +116 Branches 1059 1081 +22 ============================================ + Hits 2226 2313 +87 - Misses 5254 5277 +23 - Partials 267 273 +6 ``` | [Files](https://app.codecov.io/gh/jitsi/jicofo/pull/1137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) | Coverage Δ | | |---|---|---| | [...ofo/src/main/kotlin/org/jitsi/jicofo/xmpp/Smack.kt](https://app.codecov.io/gh/jitsi/jicofo/pull/1137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-amljb2ZvL3NyYy9tYWluL2tvdGxpbi9vcmcvaml0c2kvamljb2ZvL3htcHAvU21hY2sua3Q=) | `100.00% <100.00%> (ø)` | | | [...tsi/jicofo/conference/JitsiMeetConferenceImpl.java](https://app.codecov.io/gh/jitsi/jicofo/pull/1137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-amljb2ZvL3NyYy9tYWluL2phdmEvb3JnL2ppdHNpL2ppY29mby9jb25mZXJlbmNlL0ppdHNpTWVldENvbmZlcmVuY2VJbXBsLmphdmE=) | `44.40% <18.18%> (+0.96%)` | :arrow_up: | | [...tlin/org/jitsi/jicofo/util/PreferenceAggregator.kt](https://app.codecov.io/gh/jitsi/jicofo/pull/1137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-amljb2ZvL3NyYy9tYWluL2tvdGxpbi9vcmcvaml0c2kvamljb2ZvL3V0aWwvUHJlZmVyZW5jZUFnZ3JlZ2F0b3Iua3Q=) | `75.00% <75.00%> (ø)` | | | [...in/org/jitsi/jicofo/xmpp/muc/ChatRoomMemberImpl.kt](https://app.codecov.io/gh/jitsi/jicofo/pull/1137?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-amljb2ZvLWNvbW1vbi9zcmMvbWFpbi9rb3RsaW4vb3JnL2ppdHNpL2ppY29mby94bXBwL211Yy9DaGF0Um9vbU1lbWJlckltcGwua3Q=) | `0.00% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/jitsi/jicofo/pull/1137/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/jitsi/jicofo/pull/1137?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/jitsi/jicofo/pull/1137?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi). Last update [be8a115...c48563d](https://app.codecov.io/gh/jitsi/jicofo/pull/1137?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi).