jitsi / jicofo

JItsi COnference FOcus is a server side focus component used in Jitsi Meet conferences.
Apache License 2.0
314 stars 350 forks source link

fix: Fix scheduling jvb health checks. #1156

Closed bgrozev closed 1 month ago

bgrozev commented 1 month ago

Scheduling at a fixed rate leads to IO threads building up when a bridge becomes unresponsibe and the duration of health checks becomes longer than the health check interval.

JonathanLennox commented 1 month ago

I think your solution is the same as ScheduledExecutorService.scheduleWithFixedDelay, isn't it?

bgrozev commented 1 month ago

I actually used scheduleWithFixedDelay initially but it didn't go well :)

It Submits a periodic action that becomes enabled first after the given initial delay, and subsequently with the given delay

bgrozev commented 1 month ago

Wow, I see what you mean 🤦