jitsi / jigasi

Jigasi: a server-side application acting as a gateway to Jitsi Meet conferences. Currently allows regular SIP clients to join meetings and provides transcription capabilities.
Apache License 2.0
532 stars 297 forks source link

fix: missing return #459

Closed charles-zablit closed 2 years ago

charles-zablit commented 2 years ago

This PR fixes a missing return statement.

Without it, the code below would be executed and the JSON serializer would try to parse a non-JSON string, causing an error.

codecov[bot] commented 2 years ago

Codecov Report

Merging #459 (3ade030) into master (dda0721) will decrease coverage by 0.90%. The diff coverage is 0.00%.

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/jitsi/jigasi/pull/459/graphs/tree.svg?width=650&height=150&src=pr&token=bRTGRUW8Sz&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi)](https://codecov.io/gh/jitsi/jigasi/pull/459?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) ```diff @@ Coverage Diff @@ ## master #459 +/- ## ============================================ - Coverage 23.15% 22.25% -0.91% + Complexity 304 286 -18 ============================================ Files 69 68 -1 Lines 5812 5773 -39 Branches 790 776 -14 ============================================ - Hits 1346 1285 -61 - Misses 4235 4267 +32 + Partials 231 221 -10 ``` | [Impacted Files](https://codecov.io/gh/jitsi/jigasi/pull/459?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) | Coverage Δ | | |---|---|---| | [...rc/main/java/org/jitsi/jigasi/AbstractGateway.java](https://codecov.io/gh/jitsi/jigasi/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaml0c2kvamlnYXNpL0Fic3RyYWN0R2F0ZXdheS5qYXZh) | `68.60% <0.00%> (-11.13%)` | :arrow_down: | | [.../java/org/jitsi/jigasi/AbstractGatewaySession.java](https://codecov.io/gh/jitsi/jigasi/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaml0c2kvamlnYXNpL0Fic3RyYWN0R2F0ZXdheVNlc3Npb24uamF2YQ==) | `63.49% <0.00%> (-4.31%)` | :arrow_down: | | [src/main/java/org/jitsi/jigasi/JvbConference.java](https://codecov.io/gh/jitsi/jigasi/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaml0c2kvamlnYXNpL0p2YkNvbmZlcmVuY2UuamF2YQ==) | `43.86% <0.00%> (-1.81%)` | :arrow_down: | | [src/main/java/org/jitsi/jigasi/Main.java](https://codecov.io/gh/jitsi/jigasi/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaml0c2kvamlnYXNpL01haW4uamF2YQ==) | `22.09% <0.00%> (-1.66%)` | :arrow_down: | | [.../main/java/org/jitsi/jigasi/SipGatewaySession.java](https://codecov.io/gh/jitsi/jigasi/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaml0c2kvamlnYXNpL1NpcEdhdGV3YXlTZXNzaW9uLmphdmE=) | `47.02% <ø> (-2.25%)` | :arrow_down: | | [...java/org/jitsi/jigasi/osgi/JigasiBundleConfig.java](https://codecov.io/gh/jitsi/jigasi/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaml0c2kvamlnYXNpL29zZ2kvSmlnYXNpQnVuZGxlQ29uZmlnLmphdmE=) | `95.45% <ø> (-0.20%)` | :arrow_down: | | [...c/main/java/org/jitsi/jigasi/rest/HandlerImpl.java](https://codecov.io/gh/jitsi/jigasi/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaml0c2kvamlnYXNpL3Jlc3QvSGFuZGxlckltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...transcription/GoogleCloudTranscriptionService.java](https://codecov.io/gh/jitsi/jigasi/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaml0c2kvamlnYXNpL3RyYW5zY3JpcHRpb24vR29vZ2xlQ2xvdWRUcmFuc2NyaXB0aW9uU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | | | [...ranscription/LibreTranslateTranslationService.java](https://codecov.io/gh/jitsi/jigasi/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaml0c2kvamlnYXNpL3RyYW5zY3JpcHRpb24vTGlicmVUcmFuc2xhdGVUcmFuc2xhdGlvblNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [...va/org/jitsi/jigasi/transcription/Participant.java](https://codecov.io/gh/jitsi/jigasi/pull/459/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaml0c2kvamlnYXNpL3RyYW5zY3JpcHRpb24vUGFydGljaXBhbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | | | ... and [7 more](https://codecov.io/gh/jitsi/jigasi/pull/459/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/jitsi/jigasi/pull/459?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/jitsi/jigasi/pull/459?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi). Last update [f7232fd...3ade030](https://codecov.io/gh/jitsi/jigasi/pull/459?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi).