search

jitsi / jigasi

Jigasi: a server-side application acting as a gateway to Jitsi Meet conferences. Currently allows regular SIP clients to join meetings and provides transcription capabilities.
Apache License 2.0
525 stars 295 forks source link

feat: Implements a simple message to be set in call to check for serv… #462

Closed damencho closed 1 year ago

damencho commented 1 year ago

…er availability.

If there is a short network disruption and sip connection reconnects on TCP we may never receive the sip call BYE so we never cleanup and leak calls. This is a simple heartbeat like, sending a sip INFO message and expecting a reply, if two consecutive miss a response we drop the call, anyway it was dropped at server-side.

codecov[bot] commented 1 year ago

Codecov Report

Merging #462 (3fb55a2) into master (bbe05ec) will decrease coverage by 0.02%. The diff coverage is 23.52%.

:exclamation: Current head 3fb55a2 differs from pull request most recent head 2963e10. Consider uploading reports for the commit 2963e10 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://codecov.io/gh/jitsi/jigasi/pull/462/graphs/tree.svg?width=650&height=150&src=pr&token=bRTGRUW8Sz&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi)](https://codecov.io/gh/jitsi/jigasi/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) ```diff @@ Coverage Diff @@ ## master #462 +/- ## ============================================ - Coverage 22.24% 22.21% -0.03% + Complexity 287 286 -1 ============================================ Files 68 68 Lines 5773 5807 +34 Branches 776 780 +4 ============================================ + Hits 1284 1290 +6 - Misses 4269 4295 +26 - Partials 220 222 +2 ``` | [Impacted Files](https://codecov.io/gh/jitsi/jigasi/pull/462?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) | Coverage Δ | | |---|---|---| | [...java/org/jitsi/jigasi/sip/SipInfoJsonProtocol.java](https://codecov.io/gh/jitsi/jigasi/pull/462/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaml0c2kvamlnYXNpL3NpcC9TaXBJbmZvSnNvblByb3RvY29sLmphdmE=) | `7.69% <0.00%> (-0.38%)` | :arrow_down: | | [...c/main/java/org/jitsi/jigasi/stats/Statistics.java](https://codecov.io/gh/jitsi/jigasi/pull/462/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaml0c2kvamlnYXNpL3N0YXRzL1N0YXRpc3RpY3MuamF2YQ==) | `41.29% <25.00%> (-1.76%)` | :arrow_down: | | [.../main/java/org/jitsi/jigasi/SipGatewaySession.java](https://codecov.io/gh/jitsi/jigasi/pull/462/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi#diff-c3JjL21haW4vamF2YS9vcmcvaml0c2kvamlnYXNpL1NpcEdhdGV3YXlTZXNzaW9uLmphdmE=) | `45.87% <25.92%> (-1.15%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/jitsi/jigasi/pull/462?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/jitsi/jigasi/pull/462?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi). Last update [bbe05ec...2963e10](https://codecov.io/gh/jitsi/jigasi/pull/462?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=jitsi).