jitsi / jitsi-android

Jitsi for Android is an Android port of the Jitsi project: The most feature-rich communicator with support for encrypted audio/video, chat and presence over SIP and XMPP
Apache License 2.0
414 stars 259 forks source link

OTR issues with carbon_copy #32

Open Sebijk opened 9 years ago

Sebijk commented 9 years ago

If OTR is enabled and the XMPP server have carbons enabled, it make issues with other clients, because Jitsi for Android send it to all clients and not the private-flag.

SamWhited commented 9 years ago

Really it should contain the relavant message processing hints specified from XEP-0334 and the Carbons no-copy hint.

Eg.

  <message
                  from='malvolio@stewardsguild.lit/countesshousehold'
                  to='olivia@countess.lit/veiled'>
                <body>?OTR?v23?...</body>
                <no-copy xmlns="urn:xmpp:hints"/>
                <no-permanent-store xmlns="urn:xmpp:hints"/>
                <private xmlns="urn:xmpp:carbons:2"/>
        </message>

I've got a PR open with the XSF containing informational XEP on current OTR usage (xsf/xeps#38) which can be found in rendered form here if you're interested, or would like to contribute / review.