459below
commented
8 years ago It is not really my place to say this. I am not a maintainer of any kind and I have no affiliation (excluding the CLA) whatsoever to the Jitsi Organization. Since that is so, I can be wrong on some or all of the points I'm raising. That being said:
I think there are several problems with this pull request.
- CLA: They cannot accept your contributions, before every contributor in this pull request has signed the Contributor License Agreement. So @thrimbor, @sandy-8925, @netmackan all would need to sign this.
- Diverged: Your fork seems to be 4 commits behind the upstream repository. You would need to rebase it onto the current master branch of the jitsi repository.
- At least one of the commits is huge. Mixing several separate logical changes together. Since it's not atomic, it would be impossible to revert one logical change inside this commit.
- Some of the code doesn't seem to adhere to the Jitsi Code Convetion
netmackan
sandy-8925
As I probably won't be doing any jitsi-android development anytime soon, I decided to open this pull request to give back some of the improvements I made. Each commit falls into one of these categories:
The commits were tested and do work, a prebuilt apk is currently available at http://thrimbor.github.io/jitsi-builds/jitsi_2014-11-10.apk I ran this build on my phone for months and still have it installed.
Please feel free to leave out individual commits if you want, I just wanted to offer you these changes because I will be deleting my jitsi-android fork soon (because, as I said, I won't be working on it anytime soon).