search

jitsi / jitsi-meet-electron

Jitsi Meet desktop application powered by :electron:
Apache License 2.0
1.5k stars 460 forks source link

Screen sharing a window crashes #530

Open MartinListwan opened 3 years ago

MartinListwan commented 3 years ago

Description

Screen sharing will crash jitsi-meet-electron (Jitsi-meet-electron will close without any error message). This only happens when you have multiple monitors connected and you're screen sharing a window on the primary monitor.

Current behavior

Jitsi-meet-electron will crash consistently when you follow the steps to reproduce instead of starting a screen share.

Running Jitsi-Meet-electron from git bash and screensharing will produce the following logs.

`$ ./"Jitsi Meet.exe"

14:11:49.755 > Checking for update
(electron) 'BrowserWindow.getDevToolsExtensions' is deprecated and will be removed. Please use 'session.getAllExtensions' instead.
14:11:51.674 > Update for version 2.6.1 is not available (latest version: 2.6.1, downgrade is disallowed).
14:11:51.680 > checkForUpdatesAndNotify called, downloadPromise is null
2021-03-06T19:12:03.035Z [AOT] <logInfo>:  [MAIN] onAlwaysOnTopWindow
2021-03-06T19:12:03.036Z [AOT] <logInfo>:  [MAIN] getPosition
2021-03-06T19:12:03.038Z [AOT] <logInfo>:  [MAIN] positionWindowWithinScreenBoundaries
2021-03-06T19:12:03.038Z [AOT] <logInfo>:  [MAIN] positionWindowWithinScreenBoundaries end
2021-03-06T19:12:03.038Z [AOT] <logInfo>:  [MAIN] getSize
2021-03-06T19:12:03.098Z [AOT] <logInfo>:  [MAIN] setAspectRatioToResizeableWindow
2021-03-06T19:12:03.099Z [AOT] <logInfo>:  [MAIN] setAspectRatioToResizeableWindow end
2021-03-06T19:12:03.099Z [AOT] <logInfo>:  [MAIN] send jitsi-always-on-to new-window
2021-03-06T19:12:03.100Z [AOT] <logInfo>:  [MAIN] onAlwaysOnTopWindow end
2021-03-06T19:12:03.163Z [AOT] <logInfo>:  [MAIN] ready-to-show
2021-03-06T19:12:03.164Z [AOT] <logInfo>:  [MAIN] ready-to-show: shoInactive
2021-03-06T19:12:03.166Z [AOT] <logInfo>:  [MAIN] ready-to-show: showInactive end
Segmentation fault

Expected Behavior

Jitsi-meet-electron to not crash

Possible Solution

I'm going to guess that the crash happens when Jitsi-meet-electron calls "getUserMedia(...)" with the appropriate parameters.

Steps to reproduce

  1. Have 2 monitors connected (I assume this occurs whenever you have 2+)
  2. Screenshare a window that is on your primary window

  3. Jist-meet-electron crashes

    Environment details

Windows_NT 10 (19041.804)

saghul commented 3 years ago

Does the same thing happen when launched directly from Explorer?

MartinListwan commented 3 years ago

The bug occurs when I launch it through the shortcut / .exe file as well

saghul commented 3 years ago

Can you try 2.7.x ? We updated Electron.

MartinListwan commented 3 years ago

Attempted again after downloading and re-installing. I can confirm that it still crashes.