jitsi / jitsi-meet-electron

Jitsi Meet desktop application powered by :electron:
Apache License 2.0
1.5k stars 462 forks source link

fix: add sandbox permission to iframe #926

Closed andreicon closed 10 months ago

saghul commented 10 months ago

Change LGTM but I don't think it's enough for the download to happen. Have you tested this?

andreicon commented 10 months ago

hi, saghul,

yes, i've tested this and the issue was fixed by adding that policy.

saghul commented 10 months ago

How and where is the file actually downloaded?

andreicon commented 10 months ago

The system's default "Save File" dialog is triggered by the web view. The user can then choose a location and specify a file name. I believe excalidraw specifies a mime type for the file, so the dialog already hints the file extension.

saghul commented 10 months ago

That is pretty cool!