search

jitsi / jitsi-meet-electron

Jitsi Meet desktop application powered by :electron:
Apache License 2.0
1.48k stars 452 forks source link

Enable new macOS screen capture when we have Chromium >= 120 #934

Closed saghul closed 4 months ago

saghul commented 7 months ago

https://github.com/chromium/chromium/commit/843de713e921eac9ed07418a876ee3480833443e

csett86 commented 7 months ago

Electron 28 (due 5 dec) should already contain Chromium 120 :)

csett86 commented 5 months ago

I think just Chromium 120 is probably not enough, as I have not seen any traces in electron for this.

See eg https://github.com/electron/electron/issues/38722

saghul commented 5 months ago

That is different. The Chomium side is about using ScreenCaptureKit for capture, which is supposed to be more efficient and bring back content hiding, which was lost somewhere along the way IIRC: https://developer.apple.com/documentation/screencapturekit?language=objc

csett86 commented 5 months ago

Ok, then I got them mixed up. Is there anything we need to do, as we have Chromium 120 now as part of electron 28?

saghul commented 5 months ago

I think not!