search

jitsi / jitsi-meet-electron

Jitsi Meet desktop application powered by :electron:
Apache License 2.0
1.48k stars 452 forks source link

Jitsi electron shared Entire Screen instead of only selected Chrome browser #935

Closed seregasoft closed 7 months ago

seregasoft commented 7 months ago

Description

Jitsi electron shared Entire Screen instead of Chrome browser window. The problem is not reproduced if you use Jitsi in browser. The problem is not reproduced if you use Jitsi electron and choose any Window except Chrome browser.

Current behavior

While in a conference using the Jitsi electron, choose share a Window > Chrome browser instance The result is as if I chose to share the Entire Screen. Starts share the Entire Screen.

Expected Behavior

Starts share only selected Chrome browser windows

Possible Solution

Steps to reproduce

In Jitsi electron choose share a Window > Chrome browser instance

Environment details

Jitsi electron: v2023.11.3

OS: Windows 10

Server: jitsi-meet-prosody/stable,now 1.0.7658-1 jitsi-meet-turnserver/stable,now 1.0.7658-1 jitsi-meet-web-config/stable,now 1.0.7658-1 jitsi-meet-web/stable,now 1.0.7658-1 jitsi-meet/stable,now 2.0.9111-1 jitsi-videobridge2/stable,now 2.3-61-g814bffd6-1

saghul commented 7 months ago

Sorry I don't understand. When you select a Chrome window to share just that, what happens? CAn you share a screenshot?

seregasoft commented 7 months ago

Sorry I don't understand. When you select a Chrome window to share just that, what happens? CAn you share a screenshot?

Yes, select a Chrome window to share. But started sharing entire screen with taskbar image

saghul commented 7 months ago

CAn you reproduce this when connecting to meet.jit.si? I know we did some fixes to this lately due to a regression.

seregasoft commented 7 months ago

CAn you reproduce this when connecting to meet.jit.si? I know we did some fixes to this lately due to a regression.

It is also reproduced on meet.jit.si

saghul commented 7 months ago

@gabiborlea can you PTAL?

gabiborlea commented 7 months ago

Hei,

We have a fix for that: https://github.com/jitsi/jitsi-meet/commit/0813ae0f3c900a8fa7f1b2b7bac4b979be84300b, but unfortunately is it not yet in meet.jit.si.

gabiborlea commented 7 months ago

We'll have a meet.jit.si release shortly containing that fix.