search

jitsi / jitsi-meet-electron

Jitsi Meet desktop application powered by :electron:
Apache License 2.0
1.48k stars 452 forks source link

dev: get electron-reload back to work #943

Closed csett86 closed 5 months ago

csett86 commented 5 months ago

we lost that somewhere as part of webpack upgrades I guess, and I could not get it to work by configuring webpack differently, but just removing the line in question works and the reload also still works afterwards.

Signed-off-by: Christoph Settgast csett86_git@quicksands.de

saghul commented 5 months ago

LGTM! Isn't this something to report to electron-reload?

csett86 commented 5 months ago

From what I read in upstream electron-reload issues, webpack issues dont seem to be on their priority list. But let me check again :)

csett86 commented 5 months ago

See here from the maintainer of electron-reload:

The bottom line is: there is no valid use case for packing electron-reload with webpack.

Source: https://github.com/yan-foto/electron-reload/issues/90#issuecomment-687826933

Also electron-reload seems dormant, last commit is from July 2021, so I wont consider upstreaming for now

saghul commented 5 months ago

Makes sense, thanks for giving it a try!