search

jitsi / jitsi-meet-electron

Jitsi Meet desktop application powered by :electron:
Apache License 2.0
1.48k stars 452 forks source link

Chromium 123 added support for desktop soundsharing on linux! 🚀🚀 #945

Open fvalasiad opened 4 months ago

fvalasiad commented 4 months ago

Hello!

Finally, this very desirable feature for some of us has been added, as a matter of fact using ChromeDev I tested it and found it to be (mostly) working! Can expect the few issues here and there to be fixed by the time it reaches the stable branch.

I am opening this issue because I am unfamiliar with the development of electron apps or even this particular app, to ask when can we expect this feature to land after it has landed in chromium's stable branch. Will it be as soon as possible or is there anything that has you holding back chromium's version?

Thanks in advance! F.

Relevant link: https://issues.chromium.org/issues/40155218 Note: You can test it yourself using flathub's ChromeDev

saghul commented 4 months ago

Once there is an Electron release with that base Chromium we'll get the feature as part of the usual updates we do.

Thanks for sharing!

csett86 commented 4 months ago

And that would be Electron 30 which will come mid of April with Chromium 124: https://github.com/electron/electron/blob/main/docs/tutorial/electron-timelines.md

fvalasiad commented 2 months ago

The day has come people, remember to close the issue as completed when you update to electron 30!

csett86 commented 2 months ago

Looking at https://github.com/electron/electron/issues/10515 it seems that some electron bits might also be required to get this to work.

And then its gated to windows on the frontend as well, at the moment: https://github.com/jitsi/jitsi-meet/blob/master/react/features/screen-share/functions.ts#L34

So reopening this issue :)

fvalasiad commented 2 months ago

Looking at electron/electron#10515 it seems that some electron bits might also be required to get this to work.

And then its gated to windows on the frontend as well, at the moment: https://github.com/jitsi/jitsi-meet/blob/master/react/features/screen-share/functions.ts#L34

So reopening this issue :)

I know for certain that in vanilla chromium/chrome/brave you need to set #pulseaudio-loopback-for-cast and #pulseaudio-loopback-for-screen-share to get it to work, so maybe there are extra steps in achieving this in the electron app too? :D.

fvalasiad commented 2 months ago

Oh we actually have to wait for electron to support it separately, I see.

Well no big deal, will manage with vanilla chromium till then!