search

jitsi / jitsi-meet-react-sdk

React SDK for Jitsi Meet
Apache License 2.0
68 stars 38 forks source link

Feat: tenant option in JitsiMeeting #20

Closed debendraoli closed 1 year ago

saghul commented 2 years ago

I'm on the fence about this. Tenants are really just a prefix for the room name, but have certain implications (like the use of a different MUC URL) which need not apply too standard Jitsi Meet deployments.

That's why we left it out of the JitsiMeet component. You are welcome to pass a room name of tenant/roomName and that will work though, if you installation is tenant ready.

debendraoli commented 2 years ago

The developers using SDK can simply choose not to use tenants as it is defined to be optional, no?

Ether way, I believe standard installation is tenant ready, using SDK and using the string concatenation is kinda hack to me and believe using tenant optional on SDK can really bring the use of tenant into light.

As per my experience on Jitsi tenant feature is somewhat shadowed and you have to go great length in order to really understand.

saghul commented 2 years ago

The developers using SDK can simply choose not to use tenants as it is defined to be optional, no?

Yes and no :-) Tenants require server support. Since we don't know what your server supports, we have cautiously stayed away from exposing it directly. Note how JitsiMeetExternalAPI doesn't either, it's like a convention really.

The only place where they are well defined is JaaS, because we give them a meaning, otherwise it's basically a namespace, which can also be implemented with any room prefix and a separator, the / is what adds implications.