jitsi / jitsi-meet-react-sdk

React SDK for Jitsi Meet
Apache License 2.0
65 stars 36 forks source link

interfaceConfigOverwrite being ignored #29

Open idesignpixels opened 1 year ago

idesignpixels commented 1 year ago

version 1.3.0

The following gets completly ignored.

...
interfaceConfigOverwrite={{
  MOBILE_APP_PROMO: false,
  SHOW_JITSI_WATERMARK: false,
  DISABLE_JOIN_LEAVE_NOTIFICATIONS: true,
  SHOW_BRAND_WATERMARK: false,
  SHOW_POWERED_BY: false,
  SHOW_PROMOTIONAL_CLOSE_PAGE: false,
  JITSI_WATERMARK_LINK: '',
}}
...

When inspecting the iframe I can see the parameters are passed:

#jitsi_meet_external_api_id=3
&config.startWithAudioMuted=true
&config.disableModeratorIndicator=false
&config.enableEmailInStats=true
&interfaceConfig.MOBILE_APP_PROMO=false
&interfaceConfig.SHOW_JITSI_WATERMARK=false
&interfaceConfig.DISABLE_JOIN_LEAVE_NOTIFICATIONS=true
&interfaceConfig.SHOW_BRAND_WATERMARK=false
&interfaceConfig.SHOW_POWERED_BY=false
&interfaceConfig.SHOW_PROMOTIONAL_CLOSE_PAGE=false
&interfaceConfig.JITSI_WATERMARK_LINK=%22%22

But seem to be ignored, We're hosting ourselves, is there additional config needed to make that work?

I get the same issue when pointing to meet.jit.si instead of our server

I found this comment https://github.com/jitsi/jitsi-meet/issues/7354#issuecomment-666371078 Which mentions modifying a file directly, I assume this to be a file from the iframe code hosted on our server. How do we do this is we have deployed by forking https://github.com/jitsi/docker-jitsi-meet ?

idesignpixels commented 1 year ago

We managed to fix this by adding a custom-interface_config.js as per these instructions https://jitsi.github.io/handbook/docs/devops-guide/devops-guide-docker/#jitsi-meet-configuration

Happy to close but will keep open for a little longer to see if anyone knows why this property exists on the front end as it doesn't seem to have any affect.

jgarplind commented 10 months ago

Only the options listed here can be changed client side