search

jitsi / jitsi-meet-react-sdk

React SDK for Jitsi Meet
Apache License 2.0
65 stars 36 forks source link

npm install fails on react 17.0.2 #5

Closed THasthika closed 2 years ago

THasthika commented 2 years ago 
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: jitsi-keycloak-test@0.1.0
npm ERR! Found: react@17.0.2
npm ERR! node_modules/react
npm ERR!   react@"^17.0.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.8.0" from @jitsi/web-sdk@0.1.0
npm ERR! node_modules/@jitsi/web-sdk
npm ERR!   @jitsi/web-sdk@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
...

I think the react peerDependency needs to be updated.

saghul commented 2 years ago

Thanks for the report! @mihhu Any reason why we don't support react 17?

THasthika commented 2 years ago

It seems to work with react 17. I could install the package by adding --legacy-peer-deps option as it says in the error message.

mihhu commented 2 years ago

@THasthika, thank you for letting us know! I've opened a PR to cover react 17 as well, without you having to use that option.

THasthika commented 2 years ago

@mihhu thanks!

mihhu commented 2 years ago

@THasthika, could you please update the sdk to 0.2.0 and try again?

THasthika commented 2 years ago

tested using 0.2.0. It's working now.