jitsi / jitsi-meet-sdk-samples

Jitsi Meet mobile SDK examples (Android, iOS and React Native)
Apache License 2.0
273 stars 238 forks source link

Feature Flag not working #129

Open ricardodolnl opened 2 years ago

ricardodolnl commented 2 years ago

The feature flags aren't working anymore. I also tested it with my self-hosted server and with meet.jit.si server. I have for example on ios this:

[builder setFeatureFlag:@"add-people.enabled" withBoolean:NO];
[builder setFeatureFlag:@"invite.enabled" withBoolean:NO];

But i still get a button to invite others.

I'm using JitsiMeetSDK 4.1.0 and my self-hosted jitsi server is 2.0.6865-2

ricardodolnl commented 2 years ago

And for some reason the pipEnabled flag does work if i change it to NO or YES:

[builder setFeatureFlag:@"pip.enabled" withBoolean:NO];
saghul commented 2 years ago

All of those flags require extra configuration.

Did you set the people search URL in tour deployment's config?

Did you implement the PiP delegate method in your app?

Otherwise, that functionality won't be available, regardless of the flags.

ricardodolnl commented 2 years ago

I do understand that pip requires more configuration, that's why i wanted to hide that button. But what extra configuration would i need to do just to hide the invite button? As far as i know the feature flag is enough for that.

saghul commented 2 years ago

Not sure I understand what the problem is. Let's start again. What is the state of the buttons and how would you like to see them?

ricardodolnl commented 2 years ago

I want to hide the invite people button.

saghul commented 2 years ago

Which one? In the participants pane or the conference header?

ricardodolnl commented 2 years ago

Every button that can invite people, so both. I don't want to use that feature because i have created my own invite button/function inside my app.

saghul commented 2 years ago

Makes sense. We moved those buttons around so we must have messed up the flags handling (this used to work). We'll take a look.

ricardodolnl commented 2 years ago

Great, thank you. Will this ticket be updated when it's fixed or do I need to watch the changelog in future releases?

mehthabt commented 11 months ago

still flags are not working

saghul commented 11 months ago

What flags? On what SDK version?

mehthabt commented 11 months ago
Screenshot 2023-09-16 at 11 17 07 AM

i added these flags as Jitsi props. But these does not have any affects

saghul commented 11 months ago

None of the flags are applied? Did you try version 0.4.0?

mehthabt commented 11 months ago

i was checking with "^0.3.0" . let me try 0.4.0