search

jitsi / jitsi-meet-sdk-samples

Jitsi Meet mobile SDK examples (Android, iOS and React Native)
Apache License 2.0
273 stars 238 forks source link

Alert dialog title and message content are not translated : Permission required #133

Closed rboukadida closed 2 years ago

rboukadida commented 2 years ago

Hello,

The Alert Dialog title and the message are not translatable.

Steps to reproduce:

  1. Set the phone language to a language other than English.
  2. Start a video conference
  3. Set the camera permission to "not allowed"
  4. Join the conversation and got pop-up in language device asking for permission
  5. Deny the permission

Actual behavior:

Directly got another alert dialog in English asking for the permission again :

Title : "Permission required" Content : "Camera permission is required to participate in conferences with video. Please grant it in Settings"

Expected behavior:

The title and the message must be translatable by placing the string in the Strings file.

Server information:

Jitsi Meet version: 3.5.0

Client information:

Operating System: Android 10

saghul commented 2 years ago

I believe this was changed somewhere before SDK 4. Can you please test with the latest SDK?