jitsi / jitsi-meet-sdk-samples

Jitsi Meet mobile SDK examples (Android, iOS and React Native)
Apache License 2.0
278 stars 240 forks source link

The Conference doesn't end, The meeting continues in the background. #141

Closed Marwenklai closed 1 year ago

Marwenklai commented 2 years ago

Hello,

I have some issues related to Jitsi library for Android to report :

Issue 1 : When hanging the Jitsi conference with the red button, the session screen remains in the recent app list. When clicking on jitsi activity from recent App the session is relunched. (Expected result : when clicking on red button , the activity of jitsi conference should be removed from the recent app list .

Issue 2 : My app needs to know if there is ongoing jitsi conference, for that we check JitsiMeet.getCurrentConference() . when user clicks on Home button and kills all apps on recent app list, the JitsiMeet.getCurrentConference() returns not null value. (Expected result : after killing all apps from recent app list, the JitsiMeet.getCurrentConference() should return null since there is no visible ongoing Jisti conference activity)

Info Request : Can we customize the reduced view of Jitsi conference and remove or hide the X button from the reduced view?

Thank you. Best regards Marouen

saghul commented 2 years ago

When hanging the Jitsi conference with the red button, the session screen remains in the recent app list. When clicking on jitsi activity from recent App the session is relunched. (Expected result : when clicking on red button , the activity of jitsi conference should be removed from the recent app list .

I think that's the app's responsibility and not the SDKs, since different apps may want different things. You should be able to accomplish this by setting android:excludeFromRecents="true" in your manifest file.

My app needs to know if there is ongoing jitsi conference, for that we check JitsiMeet.getCurrentConference() . when user clicks on Home button and kills all apps on recent app list, the JitsiMeet.getCurrentConference() returns not null value. (Expected result : after killing all apps from recent app list, the JitsiMeet.getCurrentConference() should return null since there is no visible ongoing Jisti conference activity)

Is the ongoing notification still visible? The meeting could be still be ongoing if it wasn't closed properly.

Can we customize the reduced view of Jitsi conference and remove or hide the X button from the reduced view?

I think that's not possible, that button is drawn by Android, since it's a picture-in-picture view.

Marwenklai commented 2 years ago

Hello Saghul,

THank you for your response.

For this question : My app needs to know if there is ongoing jitsi conference, for that we check JitsiMeet.getCurrentConference() . when user clicks on Home button and kills all apps on recent app list, the JitsiMeet.getCurrentConference() returns not null value. (Expected result : after killing all apps from recent app list, the JitsiMeet.getCurrentConference() should return null since there is no visible ongoing Jisti conference activity)

You answered: Is the ongoing notification still visible? The meeting could be still be ongoing if it wasn't closed properly.

User A close jitsi activity from recent app . When closing the jitsi activity from recent App list,the notification related to jitsi is no more visible.But For other users, they can see that user A left the conference.On the other hand,for User A, JitsiMeet.getCurrentConference() returns the URL of the conference that he left. (Expected result : after killing all apps from recent app list, the JitsiMeet.getCurrentConference() should return null since there is no visible ongoing Jisti conference activity and no notification displayed)

thank you best regards Marouen

saghul commented 2 years ago

Got it. @tmoldovan8x8 can you PTAL when you get a chance?

Marwenklai commented 2 years ago

Hello @saghul @tmoldovan8x8 ,

Is there any updates please ?

Best Regards Marouen

tmoldovan8x8 commented 2 years ago

Hi @Marwenklai, Could you please try to update the SDK to the latest (6.0.0) and retry this scenario. I am not sure I can reproduce the issue here. You are killing the app from recents and after you relaunch it you are still getting JitsiMeet.getCurrentConference() not null? I assume you are also using a device on which picture-in-picture is not supported, since with PiP you won't be able to kill the app like that. If you are still reproducing this, could you send us some logs?

saghul commented 2 years ago

Set the notification icon.

The answer is on the error:

Invalid notification (no valid small icon):

wiemrh95 commented 2 years ago

Hello @tmoldovan8x8 ,

Regarding this question : My app needs to know if there is ongoing jitsi conference, for that we check JitsiMeet.getCurrentConference() . when user clicks on Home button and kills all apps on recent app list, the JitsiMeet.getCurrentConference() returns not null value. (Expected result : after killing all apps from recent app list, the JitsiMeet.getCurrentConference() should return null since there is no visible ongoing Jisti conference activity)

Still not fixed in version 6.1.0 and 6.0.0

Best regards , Wiem REBAH

tmoldovan8x8 commented 2 years ago

Hey @wiemrh95 could you send us the full logs I was mentioning previously? Still not able to reproduce the scenario described.

wiemrh95 commented 2 years ago

Hey @tmoldovan8x8

I attached the log, so even if the user leaves the conference by clicking the X button or when clicks on the Home button and kills all the apps in the recent apps list. JitsiMeet.getCurrentConference() always returns the url of the conference. (Expected result : the JitsiMeet.getCurrentConference() should return null since there is no visible ongoing Jisti conference activity)

JitsiLog.txt

Best regards , Wiem REBAH

wiemrh95 commented 2 years ago

This log is for version 6.1.0 , also when the user leaves the conference by clicking the X button or when he clicks the Home button and kills all applications in the list of recent applications. When the user returns to the conference, his account is found twice , Thrice .. Here is a screenshot
Screenshot

saghul commented 2 years ago

You mean the X button in the PiP window? That doesn't end the conference, it merely puts it in the background.

wiemrh95 commented 2 years ago

Hello ,

Either from the X button or when the user clicks on the Home button and kills all applications in the list of recent applications., the behavior is the same. Our problem is that JitsiMeet.getCurrentConference() returns the conference url even when the app is killed. (Expected result : the JitsiMeet.getCurrentConference() should return null since there is no visible ongoing Jisti conference activity)

Best regards ,

wiemrh95 commented 1 year ago

Are there any updates?

saghul commented 1 year ago

No, sorry. A PR would be welcome though.

coderof19clc7 commented 1 year ago

@saghul are there any updates ? I'm really need the meeting ended when the app is killed but it seem the lastest version of this sdk still not be able to do that

saghul commented 1 year ago

It's not possible to guarantee it. You are killing the app so there is very little time to do anything about it. We try to gracefully close the meeting, but it's timing sensitive, it may or may not have the time to do it, and I don't think there is anything you can do about it, sorry.

coderof19clc7 commented 1 year ago

I see, thanks for your reply

coderof19clc7 commented 1 year ago

It's not possible to guarantee it. You are killing the app so there is very little time to do anything about it. We try to >gracefully close the meeting, but it's timing sensitive, it may or may not have the time to do it, and I don't think there is >anything you can do about it, sorry. @saghul for android this issue happen when I'm inside a meeting with the fullscreen activity and kill the app by using the device task manager (it does not happen if I move the meeting into PIP mode and then close the meeting itself or the app by task manager)