jitsi / jitsi-meet-sdk-samples

Jitsi Meet mobile SDK examples (Android, iOS and React Native)
Apache License 2.0
284 stars 240 forks source link

android app can't open when AndroidManifest.xml use exported=false #160

Closed ihkilz closed 2 years ago

ihkilz commented 2 years ago

android app can't open when AndroidManifest.xml use exported=false i need to use exported=true because of app security required. or what workarounds are there to make it work?

example code in AndroidManifest.xml

<activity
            android:name=".MainActivity"
            android:exported="false"
            android:launchMode="singleTop"
            .. />
saghul commented 2 years ago

We use intent filters, which require exported=true.

Maybe they could be moved to the MainActivity, but that would require a major version bump.

If you're willing to make a PR we can discuss further during review, I think the change would be acceptable.

ihkilz commented 2 years ago

i understand but enough to have a solution to this where i can still use exported=false

i found some solution for allow jitsi meet broadcast but i don't know how to use receiver for jitsi meet.

        <receiver
          android:name=".xxxx"
          android:permission="android.permission.xxxx"
          android:exported="true">
            <intent-filter>
                <action android:name="android.xxxx" />
            </intent-filter>
        </receiver>

We use intent filters, which require exported=true.

Maybe they could be moved to the MainActivity, but that would require a major version bump.

If you're willing to make a PR we can discuss further during review, I think the change would be acceptable.