search

jitsi / jitsi-meet-sdk-samples

Jitsi Meet mobile SDK examples (Android, iOS and React Native)
Apache License 2.0
284 stars 240 forks source link

AndroidManifest update #181

Closed KolissnikBogdan closed 1 year ago

KolissnikBogdan commented 1 year ago

I think it would be appropriate to add these permissions to the AndroidManifest (for main and debug):

  <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
  <uses-permission android:name="android.permission.BLUETOOTH" />
  <uses-permission android:name="android.permission.CAMERA" />
  <uses-permission android:name="android.permission.INTERNET" />
  <uses-permission android:name="android.permission.MANAGE_OWN_CALLS" />
  <uses-permission android:name="android.permission.MODIFY_AUDIO_SETTINGS" />
  <uses-permission android:name="android.permission.RECORD_AUDIO" />
  <uses-permission android:name="android.permission.WAKE_LOCK" />
  <uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
  <uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
saghul commented 1 year ago

Makes sense indeed. Care to send a PR?

KolissnikBogdan commented 1 year ago

Makes sense indeed. Care to send a PR?

Can you describe step by step how to do it?)

KolissnikBogdan commented 1 year ago

I cloned the repository but I can't create a new branch

KolissnikBogdan commented 1 year ago

@saghul https://github.com/jitsi/jitsi-meet-sdk-samples/pull/182

saghul commented 1 year ago

Merged, thank you!