search

jitsi / jitsi-meet-sdk-samples

Jitsi Meet mobile SDK examples (Android, iOS and React Native)
Apache License 2.0
277 stars 240 forks source link

Change Language #45

Closed KhanTran closed 4 years ago

KhanTran commented 4 years ago

I am an iOS developer,Where can I change the language? Like French.

KhanTran commented 4 years ago

App is using English even though the device language is another language (Vietnamese)

pandel commented 4 years ago

+1 Please give a hint, how to change that! I'd even be totally fine with setting a fixed language at build time.

iOS Target 13.0 / XCode 11.4 / Test device Iphone 11 Pro 13.4.1

gungorhafize commented 4 years ago

+1 I stuck with same issue in Android sdk, localization not working

saghul commented 4 years ago

THere is no way to change it right now. Please open a feature request on the jitsi-meet repo.

pandel commented 4 years ago

THere is no way to change it right now. Please open a feature request on the jitsi-meet repo.

Huh? Why is already built-in language detection a feature request?

saghul commented 4 years ago

Currently the language is detected at runtime, based on the user's choice for the operating system. There is no way to manually override it. That is the feature being requested here.

pandel commented 4 years ago

No, it is not. Second posts states clearly, that OS language ist not recognized and that is what‘s requested here.

saghul commented 4 years ago

Hum, that got fixed not too long ago. What SDK version are you using?

gungorhafize commented 4 years ago

I'm using 2.8.2 version for android @saghul same issue

saghul commented 4 years ago

Ah, the fix (https://github.com/jitsi/jitsi-meet/commit/9be78c60ebed6ce5a8f62dd3baf8132b31ebd870) hasn't made its way onto a release.

pandel commented 4 years ago

Good find! Any thoughts about when this will be released? I really don't want to compile the SDK myself but rely on official releases via Cocoapods. But my app definitely has to use localized language, so...

pandel commented 4 years ago

Short info: I compiled the SDK myself, copied the frameworks over and recompiled my app, now language detection works as expected. Many thanks, @saghul! As long as it has not reached any release, I'll be using my own compiled version for now!

gungorhafize commented 4 years ago

@pandel I'm using android sdk and which frameworks did you copied and where? can you please tell us more detail about this solution? And localization works succesfully?

pandel commented 4 years ago

@gungorhafize Nothing to tell here! Just followed the instruction for manual use. I am under iOS, so I have absolutely no clue how to use it on Android, but I simply cloned the jitsi-meet Github repo and followed the instructions on how to manually compile it - normally I am using libs via Cocoapods, the package manager for Xcode development.

I think, you should simply follow this document on how to build the SDK yourself and integrate it into your project: https://jitsi.github.io/handbook/docs/dev-guide/dev-guide-android-sdk

The change mentioned by @saghul is already in the sources, just not in the prebuilt release downloads, that's all :-)

And yes, after using the manually build framework parts, the Jitsi component inside my app now starts localized.

gungorhafize commented 4 years ago

thanks for your answer! @pandel

gungorhafize commented 4 years ago

Hey my friend @saghul any thoughts about when this will be released? The fix (jitsi/jitsi-meet@9be78c6) is not exist on pre-build releases that is suggested to use. Or m I build my own SDK that will be a bit difficult because my app has been finished just language translation is an issue.

saghul commented 4 years ago

I have plans to make one this week.

iamlixinxin commented 3 years ago

I have plans to make one this week. I pulled up the latest code，and build iOS SDK by myself. But it still not work.