jitsi / jitsi-meet-torture

Apache License 2.0
161 stars 149 forks source link

feat: update to test components with improved accessibility #619

Closed emrahcom closed 11 months ago

emrahcom commented 11 months ago

This PR updates breakout-room and av-moderation scripts to test buttons and context menu with improved accessibility after https://github.com/jitsi/jitsi-meet/pull/13669.

These tests also work with the current master branch.

jitsi-jenkins commented 11 months ago

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

damencho commented 11 months ago

Jenkins test this please.

emrahcom commented 11 months ago

@damencho, Jenkins test looks failed. Is it related with this PR or something else..?

I tested updated test scripts against stable-8960 (my local Jitsi setup) and alpha.jitsi.net and they all passed.

mvn test -DallowInsecureCerts=true \
  -Djitsi-meet.tests.toRun="BreakoutRoomsTest,AudioVideoModerationTest" \
  -Djitsi-meet.instance.url="https://alpha.jitsi.net"
damencho commented 11 months ago

Hum, I see from the logs It used the correct branch for jitsi-meet and jitsi-meet-torture

damencho commented 11 months ago

O you know, there was a broken node in our grid. I will re-run it.

damencho commented 11 months ago

Now it looks better. Not that I see what is the problem:

element click intercepted: Element <button aria-label="More moderation options" class="iconButton css-15qz9wz-button-secondary-iconButton-medium" id="participants-pane-context-menu" title="More moderation options" type="button" data-focus-on-hidden="true" aria-hidden="true">...</button> is not clickable at point (1356, 556). 

Other element would receive the click: <div class="css-197os2p-footerMoreContainer">...</div>

org jitsi meet test AudioVideoModerationTest-web participant1

Not sure what is that footerMoreContainer ...

emrahcom commented 11 months ago

Is this the result against this PR? If so that means I'm missing something

damencho commented 11 months ago

I think so.

You can can see in https://pr-reports.jitsi.org/jitsi-meet-torture-PR-test/1094/log.txt

+ git pull https://github.com/nordeck/jitsi-meet-torture-2.git nic/feat/accessibility/brekout
+ git pull https://github.com/nordeck/jitsi-meet.git nic/feat/accessibility/brekout
From https://github.com/nordeck/jitsi-meet
emrahcom commented 11 months ago

Finally I can reproduce the same issue on my local after switching Chrome 117

emrahcom commented 11 months ago

@damencho, could you test it again please.

I updated unfocus method while closing the context menu.

damencho commented 11 months ago

Jenkins, test this please.