search

jitsi / jitsi-meet

Jitsi Meet - Secure, Simple and Scalable Video Conferences that you use as a standalone app or embed in your web application.
https://jitsi.org/meet
Apache License 2.0
23.26k stars 6.75k forks source link

waitForOwnerDialog appears after successful authorization #12806

Closed W0olFy closed 1 year ago

W0olFy commented 1 year ago

Description:

When you press "Login" button on loginDialog it hides itself immediately, and waitForOwnerDialog appears after you saw "CONFERENCE FAILED: conference.authenticationRequired" error in browser console, but authorization process is not finished yet... If user do nothing, he will be moved to conference and waitForOwnerDialog will close, but usually users think that they do something wrong and trying to authorize one more time. Confusing..

Steps to reproduce:

  1. Configure secure domain and authorization (ldap for example)
  2. Create new conference
  3. Press "Join meeting" button
  4. Press "I am the host" button
  5. Input your login/password (do not press "Login" button)
  6. Wait for "CONFERENCE FAILED: conference.authenticationRequired" error appears in browser console
  7. Count to 3 or 4
  8. Press "Login" button

You should see waitForOwnerDialog appears, but authorization process is in progress.

Expected behavior:

loginDialog shows status of authorization process and closes when finished

Actual behavior:

waitForOwnerDialog appears after successful authorization

Server information:

Client information:

Additional information:

To correct this bug, please add disableAutoHideOnSubmit = { true } after or before this line: https://github.com/jitsi/jitsi-meet/blob/507d88350320521de51d27f908b6708fb14f278d/react/features/authentication/components/web/LoginDialog.tsx#L256

saghul commented 1 year ago

To correct this bug, please add disableAutoHideOnSubmit = { true } after or before this line:

Not sure that's the right fix, because the dialog shows the auth pogress in a text line, doesn't it? We might have broken that with the dialogs refactoring.

W0olFy commented 1 year ago

To correct this bug, please add disableAutoHideOnSubmit = { true } after or before this line:

Not sure that's the right fix, because the dialog shows the auth pogress in a text line, doesn't it? We might have broken that with the dialogs refactoring.

Patched it in app.bundle.min.js and bug is gone. Before, loginDialog just close immediatly after "Login" button was pressed. Now it works as expected, showing authorization status while it is in progress and closes right after it finishes. In previous versions, before dialog refactoring, Event.preventDefault() method was used and all was working.

saghul commented 1 year ago

Ah, sorry I got it backwards. You are right. Would you like to send a PR?

W0olFy commented 1 year ago

Ah, sorry I got it backwards. You are right. Would you like to send a PR?

https://github.com/jitsi/jitsi-meet/pull/12808

Done, Thanks!

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.