search

jitsi / jitsi-meet

Jitsi Meet - Secure, Simple and Scalable Video Conferences that you use as a standalone app or embed in your web application.
https://jitsi.org/meet
Apache License 2.0
23.22k stars 6.75k forks source link

Edit HTML files in new version of Jitsi MEet #1346

Closed Yomibamms closed 7 years ago

Yomibamms commented 7 years ago

Installed the latest version. Been trying to locate the HTML files so I can make some editing but haven't been able to locate them. I know react.js might have been implemented, but please guide on how I can make UI changes. Searched for over 2 days and not found Please help

saghul commented 7 years ago

What are you looking for specifically? They are all here. Except for the parts written with react, which are in the react/ directory.

PS: Please use the mailing list for questions, we keep the issue tracker just for issues.

Yomibamms commented 7 years ago

For instance, Looking for the welcome page HTML folder to make adjustments They are all where please?

  From: Saúl Ibarra Corretgé <notifications@github.com>

To: jitsi/jitsi-meet jitsi-meet@noreply.github.com Cc: bamms baa_yoo@yahoo.com; Author author@noreply.github.com Sent: Wednesday, February 22, 2017 7:58 AM Subject: Re: [jitsi/jitsi-meet] Edit HTML files in new version of Jitsi MEet (#1346)

What are you looking for specifically? They are all here. Except for the parts written with react, which are in the react/ directory.PS: Please use the mailing list for questions, we keep the issue tracker just for issues.— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Yomibamms commented 7 years ago

Din't really get the directory you referred to as 'They are all here'. Please guide Thanks

  From: Saúl Ibarra Corretgé <notifications@github.com>

To: jitsi/jitsi-meet jitsi-meet@noreply.github.com Cc: bamms baa_yoo@yahoo.com; Author author@noreply.github.com Sent: Wednesday, February 22, 2017 7:58 AM Subject: Re: [jitsi/jitsi-meet] Edit HTML files in new version of Jitsi MEet (#1346)

What are you looking for specifically? They are all here. Except for the parts written with react, which are in the react/ directory.PS: Please use the mailing list for questions, we keep the issue tracker just for issues.— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

saghul commented 7 years ago

I meant "here" as in "in this repo". Here is the welcome page, for example: https://github.com/jitsi/jitsi-meet/blob/master/react/features/welcome/components/WelcomePage.web.js

Yomibamms commented 7 years ago

Thanks But all the changes I try to make in the file is not reflecting online. And even when I try to rename the file so the jisto home page disappears, it still didnt make any difference on the Home page. What I still have on the home page is the jisti design and i need to adjust it. 

Please kindly guide on how to make adjustments to the jitsi home page UI Thanks

  From: Saúl Ibarra Corretgé <notifications@github.com>

To: jitsi/jitsi-meet jitsi-meet@noreply.github.com Cc: bamms baa_yoo@yahoo.com; Author author@noreply.github.com Sent: Wednesday, February 22, 2017 8:34 AM Subject: Re: [jitsi/jitsi-meet] Edit HTML files in new version of Jitsi MEet (#1346)

I meant "here" as in "in this repo". Here is the welcome page, for example: https://github.com/jitsi/jitsi-meet/blob/master/react/features/welcome/components/WelcomePage.web.js— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

saghul commented 7 years ago

You need to "build" the site after you make changes, this is no different than any modern web application using React.

Please use the mailing list for such questions.

Yomibamms commented 7 years ago

Hi Saúl,Hi All, Tried following your guide Saul, to build the site after making changes. Tried running "npm run start:web" Inside path/jitsi-meet But got the error  "Missing script: start:web" Kindly guide me to  let me know how to do the building. Just started playing with react on ubuntu server Thank you.

Please all, find initial orginal issue below:

All the changes I try to make in the latest jitsi home page file online is not reflecting online. And even when I try to rename the file so the jisti home page disappears, it still didnt make any difference on the Home page. What I still have on the home page is the jisti design and i need to adjust it. 

Please kindly guide on how to make adjustments to the jitsi home page UI Thanks From: Saúl Ibarra Corretgé notifications@github.com To: jitsi/jitsi-meet jitsi-meet@noreply.github.com Cc: bamms baa_yoo@yahoo.com; Author author@noreply.github.com Sent: Monday, February 27, 2017 2:01 AM Subject: Re: [jitsi/jitsi-meet] Edit HTML files in new version of Jitsi MEet (#1346)

You need to "build" the site after you make changes, this is no different than any modern web application using React.Please use the mailing list for such questions.— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

Yomibamms commented 7 years ago

PLEASE HELP!!!! The new react system really needs a proper guide/documentation. Tried and Tried and Tried to build as Saul suggested Home page changes are not reflecting and my application is live!  keep getting error when I try building. Maybe because am a bit new to REact, but a guide will help. I copied the package.json and webpack.config.js from here "https://github.com/jitsi/jitsi-meet" into my ubuntu.  But the "npm run start:web" will still not run. Various errorsLatest one is attached I need a guide please!

  From: Abayomi Bamiwo <baa_yoo@yahoo.com>

To: dev@jitsi.org Sent: Tuesday, February 28, 2017 6:22 AM Subject: Fw: [jitsi/jitsi-meet] Edit HTML files in new version of Jitsi MEet (#1346)

----- Forwarded Message ----- From: Abayomi Bamiwo baa_yoo@yahoo.com To: jitsi/jitsi-meet reply@reply.github.com; "users@jitsi.org" users@jitsi.org Cc: Author author@noreply.github.com Sent: Tuesday, February 28, 2017 6:10 AM Subject: Re: [jitsi/jitsi-meet] Edit HTML files in new version of Jitsi MEet (#1346)

Hi Saúl,Hi All, Tried following your guide Saul, to build the site after making changes. Tried running "npm run start:web" Inside path/jitsi-meet But got the error  "Missing script: start:web" Kindly guide me to  let me know how to do the building. Just started playing with react on ubuntu server Thank you.

Please all, find initial orginal issue below:

All the changes I try to make in the latest jitsi home page file online is not reflecting online. And even when I try to rename the file so the jisti home page disappears, it still didnt make any difference on the Home page. What I still have on the home page is the jisti design and i need to adjust it. 

Please kindly guide on how to make adjustments to the jitsi home page UI Thanks From: Saúl Ibarra Corretgé notifications@github.com To: jitsi/jitsi-meet jitsi-meet@noreply.github.com Cc: bamms baa_yoo@yahoo.com; Author author@noreply.github.com Sent: Monday, February 27, 2017 2:01 AM Subject: Re: [jitsi/jitsi-meet] Edit HTML files in new version of Jitsi MEet (#1346)

You need to "build" the site after you make changes, this is no different than any modern web application using React.Please use the mailing list for such questions.— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

saghul commented 7 years ago

Please, be polite, using caps in an online communication is considered shouting, and that's not welcome here.

Now, when I told you you needed to build the app I also told you to have a look at the README. Please see here: https://github.com/jitsi/jitsi-meet#building-the-sources

I'm not sure where you got the idea that npm run start:web would work, but definitely not from our documentation.

So, after making your changes and running make as the README suggests your app should reflect the changes just fine.

Last, while I agree our documentation is sorely lacking, there is nothing special about Jitsi Meet, it's a web application which uses React, so official react documentation applies.

Yomibamms commented 7 years ago

Thanks alot saul I applogize for the 

Had alot of pressure because I was live and needed to make the adjustment urgently Will also see how I can gelp with the doc once I get it and also master the react appropiately Will follow your guide and revert Thank for always being patience with response. you deserve the nomination :)

Sent from Yahoo Mail on Android

On Thu, Mar 2, 2017 at 10:39 AM, Saúl Ibarra Corretgénotifications@github.com wrote:
Please, be polite, suing caps in an online communication is considered shouting, and that's not welcome here.

Now, when I told you you needed to build the app I also told you to have a look at the README. Please see here: https://github.com/jitsi/jitsi-meet#building-the-sources

I'm not sure where you got the idea that npm run start:web would work, but definitely not from our documentation.

So, after making your changes and running make as the README suggests your app should reflect the changes just fine.

Last, while I agree our documentation is sorely lacking, there is nothing special about Jitsi Meet, it's a web application which uses React, so official react documentation applies.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.