search

jitsi / jitsi-meet

Jitsi Meet - Secure, Simple and Scalable Video Conferences that you use as a standalone app or embed in your web application.
https://jitsi.org/meet
Apache License 2.0
23.24k stars 6.75k forks source link

E2EE option not available in Firefox #14626

Closed Be-ing closed 7 months ago

Be-ing commented 7 months ago

Description:

Implementing E2EE with RTCRtpScriptTransform (https://github.com/jitsi/jitsi-meet/issues/9585) was implemented in https://github.com/jitsi/lib-jitsi-meet/pull/1696. At the time it was implemented in Jitsi, only WebKit supported that API. As of Firefox 117, Firefox also supports RTCRtpScriptTransform. However, no option for E2EE appears in the security setting when Jitsi is run in Firefox 124.

Steps to reproduce:

  1. Join a meeting
  2. Right click and go to security options

Expected behavior:

Option to toggle E2EE is shown among the security options.

Actual behavior:

No option regarding E2EE is shown.

Opening the meeting in Chromium shows the E2EE setting as expected.

Server information:

Using meet.jit.si

Client information:

damencho commented 7 months ago

Please, when you have questions or problems use the community forum before opening new issues, thank you.

This is already available and implemented as you pointed the PR. You can use the URL params to enable it.

As the comment says it is experimental and turned off by default in jitsi-meet and on meet.jit.si https://github.com/jitsi/jitsi-meet/blob/42a0c31a3acdf8a9886e9ac00a7bd8b85996ca2b/config.js#L615

Be-ing commented 7 months ago

Please read the bug report carefully before dismissing it. It's not a usage question. Within the same meeting on meet.jit.si, the option was available in Chromium. It is a bug that it was not shown in Firefox.

saghul commented 7 months ago

It's behind an experimental flag still. You can flip the flag with a URL parameter for testing.

Be-ing commented 7 months ago

If it's behind an experimental flag, why does the option appear in Chromium without any special URL parameter?

saghul commented 7 months ago

No, the experimental flag is for the Script transform approach taken by Safari and lately Firefox.

saghul commented 7 months ago

https://github.com/jitsi/jitsi-meet/blob/b470c201b28a8103d7d1bd8cf44c6dc3651caa34/config.js#L619

Be-ing commented 7 months ago

No, the experimental flag is for the Script transform approach taken by Safari and lately Firefox.

Ah, that explains it. So adding #enableEncodedTransformSupport=true to the URL should enable the option? What is required for this to no longer be experimental?

saghul commented 7 months ago

So adding #enableEncodedTransformSupport=true to the URL should enable the option?

Correct.

What is required for this to no longer be experimental?

For it to work properly. Safari had a bug where they only passed one of the simulcast layers through the transformer, for example.