jitsi / jitsi-meet

Jitsi Meet - Secure, Simple and Scalable Video Conferences that you use as a standalone app or embed in your web application.
https://jitsi.org/meet
Apache License 2.0
22.1k stars 6.58k forks source link

Setting 'call-integration.enabled' value to true makes impossible to play video when shared via youtube link #14812

Open mdhanif-simformsolutions opened 1 month ago

mdhanif-simformsolutions commented 1 month ago

Hi,

I've installed Jitsi demo app from :- https://github.com/jitsi/jitsi-meet-sdk-samples

In the code :-

MainActivity File

val defaultOptions = JitsiMeetConferenceOptions.Builder()
                .setServerURL(serverURL)
                // When using JaaS, set the obtained JWT here
                //.setToken("MyJWT")
                // Different features flags can be set
                //.setFeatureFlag("toolbox.enabled", false)
                //.setFeatureFlag("filmstrip.enabled", false)
                .setFeatureFlag("call-integration.enabled", true).  // Add this flag and set to true
                .build()
        JitsiMeet.setDefaultConferenceOptions(defaultOptions)

If I add .setFeatureFlag("call-integration.enabled", true) at any place it makes impossible to play video when shared via youtube url.

This happens in Jitsi sample demo as well.

Although this is not mentioned in the description of the given feature flag which makes it confusing.

Platform

Browser / app / sdk version

9.2.2

Relevant log output

No response

Reproducibility

More details?

No response

saghul commented 1 month ago

We ran into many problems with ConnectionService, that's why it's off by default :-( I wasn't aware of this one though...

mdhanif-simformsolutions commented 1 month ago
Screenshot 2024-06-07 at 8 00 06 PM

Still documentation shows it ON by default

Should probably update that as well

saghul commented 1 month ago

Good point!

mdhanif-simformsolutions commented 1 month ago

Do you think this can be fixed ? We need this feature enable for all platforms and not run into this kind of issues ?

saghul commented 1 month ago

I don't know how, but if you figure it out, a PR would be welcome.