jitsi / jitsi-meet

Jitsi Meet - Secure, Simple and Scalable Video Conferences that you use as a standalone app or embed in your web application.
https://jitsi.org/meet
Apache License 2.0
22.79k stars 6.67k forks source link

@jitsi/react-native-sdk does not work with React Native 0.74.3 #14912

Open danchily2 opened 1 month ago

danchily2 commented 1 month ago

What happened?

The issue seems to be cause by @react-native-community/clipboard dependency which is outdate. Is it possible to remove this dependency from @jitsi/react-native-sdk ?

Platform

Browser / app / sdk version

"@jitsi/react-native-sdk": "^2.2.1"

Relevant log output

Projects/event-native-app/event-native-app/node_modules/@react-native-community/clipboard/android/src/main/java/com/reactnativecommunity/clipboard/ClipboardModule.java:14: error: cannot find symbol
import com.facebook.react.bridge.ContextBaseJavaModule;
                                ^
  symbol:   class ContextBaseJavaModule
  location: package com.facebook.react.bridge
Projects/event-native-app/event-native-app/node_modules/@react-native-community/clipboard/android/src/main/java/com/reactnativecommunity/clipboard/ClipboardModule.java:23: error: cannot find symbol
public class ClipboardModule extends ContextBaseJavaModule {
                                     ^
  symbol: class ContextBaseJavaModule
Projects/event-native-app/event-native-app/node_modules/@react-native-community/clipboard/android/src/main/java/com/reactnativecommunity/clipboard/ClipboardPackage.java:23: error: incompatible types: ClipboardModule cannot be converted to NativeModule
    modules.add(new ClipboardModule(reactContext));
                ^
Projects/event-native-app/event-native-app/node_modules/@react-native-community/clipboard/android/src/main/java/com/reactnativecommunity/clipboard/ClipboardModule.java:31: error: method does not override or implement a method from a supertype
  @Override
  ^
Projects/event-native-app/event-native-app/node_modules/@react-native-community/clipboard/android/src/main/java/com/reactnativecommunity/clipboard/ClipboardModule.java:37: error: cannot find symbol
    return (ClipboardManager) getContext().getSystemService(getContext().CLIPBOARD_SERVICE);
                                                            ^
  symbol:   method getContext()
  location: class ClipboardModule
Projects/event-native-app/event-native-app/node_modules/@react-native-community/clipboard/android/src/main/java/com/reactnativecommunity/clipboard/ClipboardModule.java:37: error: cannot find symbol
    return (ClipboardManager) getContext().getSystemService(getContext().CLIPBOARD_SERVICE);
                              ^
  symbol:   method getContext()
  location: class ClipboardModule
Note: Some messages have been simplified; recompile with -Xdiags:verbose to get full output
6 errors

FAILURE: Build failed with an exception.


### Reproducibility

- [ ] The problem is reproducible on meet.jit.si

### More details?

_No response_
saghul commented 1 month ago

We have updated all dependencies and made the SDK compatible with RN 0.73, the release will be coming soon.

serifkazan commented 1 month ago

Hi same issue after release 10.0.0.

I changed "ContextBaseJavaModule" with "ReactContextBaseJavaModule" but after that i get "Type com.reactnativecommunity.clipboard.BuildConfig is defined multiple times:"

saghul commented 1 month ago

We use 0.73, not 0.74. More changes are likely needed.