Closed Holofox closed 1 month ago
Unfortuately Reanimated is a tricky one to integrate, because we don't rely on Application inheriting from ReactApplication, which, last I checked, Reanimated relied upon.
@saghul, now it’s clear, I’ll go the other way, thanks!
https://github.com/software-mansion/react-native-reanimated/issues/2719
With great difficulty, but I solved the problem. To do this, we had to implement the following changes:
android/sdk/src/main/java/org/jitsi/meet/sdk/ReactInstanceManagerHolder.java:
// ...
static List<ReactPackage> getReactNativePackages() {
List<ReactPackage> packages
= new ArrayList<>(Arrays.asList(
// ...
new com.swmansion.reanimated.ReanimatedPackage() {
@Override
public ReactInstanceManager getReactInstanceManager(ReactApplicationContext reactContext) {
return ReactInstanceManagerHolder.getReactInstanceManager();
}
},
// ...
));
// ...
android/sdk/build.gradle:
dependencies {
// ...
implementation project(':react-native-reanimated')
// ...
}
android/build.gradle:
allprojects {
// ...
project.ext.react = [
enableHermes: false,
]
// ...
}
android/gradle.properties:
// ...
hermesEnabled=false
android/settings.gradle:
// ...
include ':react-native-reanimated'
project(':react-native-reanimated').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-reanimated/android')
FYI @saghul
Great to hear!
What happened?
Hello!
There was a need to add a react-navigation/drawer and connect the react-native-reanimated dependency. I'm currently using jitsi-meet with commit ce727d87a8072c0b9a1cb70c8a9186374e3702b1 (tried also the latest changes 1376f5909c1548d507d4d4b11a332a8a6a217613).
package.json
babel.config.js
On iOS everything works great, but on Android there is a problem when going to the router with drawer:
ConferenceDrawerNavigator.tsx
ConferenceNavigationContainer.tsx
I'm new to React Native, can you please tell me what could be causing this? Is there anything that might be preventing this from happening in Jitsi right now? I tried different dependency versions, but it didn't solve the problem.
I understand that my problem does not apply to the stable version of Jitsi Meet, but I really need help to understand the problem. Any comments will help figure this out.
Platform
Browser / app / sdk version
9.2.2
Relevant log output
No response
Reproducibility
More details?
No response