Authentication dialog is missing autocomplete attributes - Githubissues

jitsi / jitsi-meet

Jitsi Meet - Secure, Simple and Scalable Video Conferences that you use as a standalone app or embed in your web application.

https://jitsi.org/meet

Apache License 2.0

22.82k stars 6.68k forks source link

Authentication dialog is missing autocomplete attributes #14974

Open otbutz opened 1 month ago

otbutz commented 1 month ago

What happened?

The login mask should use the HTML autocomplete attribute for its input fields to assist password managers:

grafik

Username:

autocomplete="username"

Password:

autocomplete="current-password"

see https://www.chromium.org/developers/design-documents/form-styles-that-chromium-understands/

Platform

[ ] Chrome (or Chromium based)
[X] Firefox
[ ] Safari
[ ] Other desktop browser
[ ] Android browser
[ ] iOS browser
[ ] Electron app
[ ] Android mobile app
[ ] iOS mobile app
[ ] Custom app using a mobile SDK

Browser / app / sdk version

Firefox 128.0.3

Relevant log output

No response

Reproducibility

[ ] The problem is reproducible on meet.jit.si

More details?

No response

saghul commented 1 month ago

Sounds reasonable! Would you be open to sending a PR?