search

jitsi / jitsi-meet

Jitsi Meet - Secure, Simple and Scalable Video Conferences that you use as a standalone app or embed in your web application.
https://jitsi.org/meet
Apache License 2.0
23.27k stars 6.76k forks source link

Added heart reaction feature #15291

Closed KingRain closed 1 week ago

KingRain commented 1 week ago

Closes https://github.com/jitsi/jitsi-meet/issues/15211

Added the heart reaction icon to the Reaction pane and also the necessary audio files for the reaction.

jitsi-jenkins commented 1 week ago

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

damencho commented 1 week ago

What is the origin of the sound files?

KingRain commented 1 week ago

What is the origin of the sound files?

They are from https://uppbeat.io/ made by Epic Stock Media

damencho commented 1 week ago

Drop the last commit, it is not relevant to this feature.

damencho commented 1 week ago

jenkins test this please.

damencho commented 1 week ago

jenkins test this please.

damencho commented 1 week ago

Cheers! Thank you for your contribution.

bgrozev commented 1 day ago

Thanks for the contribution! Please use ~/resources/encode-sound.sh to encode the files next time (to keep the size smaller and formats consistent)