search

jitsi / jitsi-meet

Jitsi Meet - Secure, Simple and Scalable Video Conferences that you use as a standalone app or embed in your web application.
https://jitsi.org/meet
Apache License 2.0
23.08k stars 6.71k forks source link

No Mute While Playing Youtube Video Share #2540

Closed kirkjaa closed 6 years ago

kirkjaa commented 6 years ago

Hello,

Could you please point me to the right direction as far as the codes for no mute when we share youtube video please ? Since our requirement is in musical training and we need to have the voice over when youtube video is playing. Thank you.

damencho commented 6 years ago

All the code about sharing youtube video is here: https://github.com/jitsi/jitsi-meet/blob/master/modules/UI/shared_video/SharedVideo.js

The problem is when the video starts playing on all participant in the conference, and there are some unmuted the audio from the video clip can be heard 3-4-5 times from all participants (as many times as the number of unmuted participants) and this is very annoying and unusable.

kirkjaa commented 6 years ago

Hello,

Gotcha and I understand the feed back loops of video will distort audio in the overall conference. Well noted on the possible issue and thank you so much,

Regards,

Kirk

On Thu, Mar 1, 2018 at 1:10 PM, Дамян Минков notifications@github.com wrote:

All the code about sharing youtube video is here: https://github.com/jitsi/jitsi-meet/blob/master/modules/UI/shared_video/ SharedVideo.js

The problem is when the video starts playing on all participant in the conference, and there are some unmuted the audio from the video clip can be heard 3-4-5 times from all participants (as many times as the number of unmuted participants) and this is very annoying and unusable.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jitsi/jitsi-meet/issues/2540#issuecomment-369484550, or mute the thread https://github.com/notifications/unsubscribe-auth/AJkSDtrcycxyWArseT01v9X5Do-094MSks5tZ5DCgaJpZM4SXyq4 .

Sidem commented 5 years ago

Is this issue ever going to be resolved? there is demand for being able to speak while a video is playing.

n3rdcoach commented 4 years ago

I have the same question, or better said: i need the option for "no one is muted during youtube-video" too. Any workarounds known?

Thank you in advance

damencho commented 4 years ago

This is intentional as this can lead to unbearable multiplied echo, we had been experimenting with that in the past, and the only usable option is the current one.

afska commented 4 years ago

Could you add it as a configurable setting? I've used other apps to share videos and it should work OK if all are using headphones

gadjodilo83 commented 4 years ago

This is intentional as this can lead to unbearable multiplied echo, we had been experimenting with that in the past, and the only usable option is the current one.

Could you add it as a configurable setting? I've used other apps to share videos and it should work OK if all are using headphones

i would like that too. we only have meetings with headphones. is there a way to change the mute in the code afterwards? it runs under ubuntu.

unfortunately i can't find any entries in the config files.

thanks marc

eggpi commented 4 years ago

There's one workaround, which may itself be a bug.

  1. Make sure you are wearing headphones :)
  2. Set a shared video, which mutes all participants.
  3. Start talking to make the "Trying to speak? You're muted" popup appear.
  4. Click "Unmute" on the popup which, unlike the regular mute/unmute button, unmutes you without muting the video.
  5. Avoid any interaction with the video, as that mutes people again.

It is confusing that (say) lowering the volume of a video causes participants to be muted as a side effect, or that my intent as a user is second-guessed when I get auto-muted after I've unmuted.

Maybe it would make sense to mute participants when a video is first shared, with a notice for why that happened in a popup, and then not auto-mute if they un-mute themselves?

gabriellucius commented 4 years ago

There's one workaround, which may itself be a bug.

  1. Make sure you are wearing headphones :)
  2. Set a shared video, which mutes all participants.
  3. Start talking to make the "Trying to speak? You're muted" popup appear.
  4. Click "Unmute" on the popup which, unlike the regular mute/unmute button, unmutes you without muting the video.
  5. Avoid any interaction with the video, as that mutes people again.

It is confusing that (say) lowering the volume of a video causes participants to be muted as a side effect, or that my intent as a user is second-guessed when I get auto-muted after I've unmuted.

Maybe it would make sense to mute participants when a video is first shared, with a notice for why that happened in a popup, and then not auto-mute if they un-mute themselves?

Wow, thanks! I need that function too. This "bug" is helping me a lot.

I will really apprecciate this as a feature possible to be enabled

kommhoerauf commented 4 years ago

The workaround is ok, but I liked to have a proper solution.

You may checkout the jitsi-meet code and change the code. I have prepared a quick patch for you https://pastebin.com/Gr1Zh3m7 . If you just follow the deploy part of the installation guide https://github.com/jitsi/jitsi-meet/blob/master/doc/manual-install.md#deploy-jitsi-meet you should be able to build the necessary libs.

In my case (ubuntu 18.04 - Jitsi-Meet quick-installation) the related libs generated from code where the following

/usr/share/jitsi-meet/libs/app.bundle.min.js
/usr/share/jitsi-meet/libs/app.bundle.min.map

Just be aware when updating you may loose your changes. The patch files for these 2 files where a bit too big to put them here ;)

Now works fine for me!

cddf commented 4 years ago

I think it would be nice to have an option to disable the automatic muting.

And I really don't get the problem with it. Of course, the feedback can be an issue with speakers, but there's no physical difference between played Youtube sound and sound of somebody who is speaking.

The point is, the (really nice) feature gets a bit useless without the possibility to speak spontaneously.

And by the way, thank you all for your really nice work. It's rather convenient in Corona times :)

rugk commented 4 years ago

I agree that users should at least be able to unmute themselves. When they have proper headphones, no audio loop will appear.

jvschiavo commented 3 years ago

+1 for that, please. I like to watch videos with my friends and talking over them like we used to do with Rabbit and now this simply is not possible.

rugk commented 3 years ago

BTW if anyone is looking for an alternative solution for now, you can also use a service like https://getmetastream.com/ (which is also FLOSS) to watch any video together with your friends. It is actually also better, because it e.g. supports any website – not only YouTube.

jvschiavo commented 3 years ago

There's one workaround, which may itself be a bug.

  1. Make sure you are wearing headphones :)
  2. Set a shared video, which mutes all participants.
  3. Start talking to make the "Trying to speak? You're muted" popup appear.
  4. Click "Unmute" on the popup which, unlike the regular mute/unmute button, unmutes you without muting the video.
  5. Avoid any interaction with the video, as that mutes people again.

It is confusing that (say) lowering the volume of a video causes participants to be muted as a side effect, or that my intent as a user is second-guessed when I get auto-muted after I've unmuted.

Maybe it would make sense to mute participants when a video is first shared, with a notice for why that happened in a popup, and then not auto-mute if they un-mute themselves?

I was using this "bug" to workaround this stupid behavior and watch videos and comment with my friends but now this simply isn't working anymore DDDD:

Are you guys able to still use it? @eggpi @gabriellucius

Also, one more time, please change this behavior so at least we can unmute and stay unmuted! There are already options to mute everyone in the room!! >.<'

RenegadeButcher commented 1 year ago

At least provide an option in the config to not mute by default. It's a bit ridiculous that a 5 year old issue has been closed twice with no resolution when this is clearly a tweak that people want.

saghul commented 1 year ago

If it's clearly something people want someone would have sent a patch.

It's a good indicator for how many and how badly people want things.