search

jitsi / jitsi-meet

Jitsi Meet - Secure, Simple and Scalable Video Conferences that you use as a standalone app or embed in your web application.
https://jitsi.org/meet
Apache License 2.0
23.07k stars 6.7k forks source link

Call for help - bug marshall programme #6656

Closed saghul closed 4 years ago

saghul commented 4 years ago

Hey all,

As discussed in today's community call (https://youtu.be/kmBYc7xV-vE?t=356) we are calling our beloved community for help witth bug triaging and issue management.

If you would like to help the projet by labeling issues, closing duplicates, ensuring discusssions are kep civil and general bug triaging right here on GitHub, please leave a comment here.

Thanks @luixxiul for raising https://github.com/jitsi/jitsi-meet/issues/6164 which kicked off this discussion.

saghul commented 4 years ago

@luixxiul @MagicFab You have both been invited to the @jitsi/bug-marshalls team. Welcome aboard and thanks for volunteering to help! 🙏

l3d00m commented 4 years ago

Hi @saghul, in case you're still interested in additional "bug marshals", I can offer my help as well. I currently have a bit spare time over the next month that I could use to label older issues and remove duplicates. I previously did that for https://github.com/ccrama/Slide, where I was an active contributor and developer for around a year.

saghul commented 4 years ago

@l3d00m Thanks for volunteering! Jusst added you to the team.

l3d00m commented 4 years ago

Pinging @toby63 and @echolon as they were both pretty active at linking duplicates.

Echolon commented 4 years ago

Yes yes yes :heart:

I would really like to help because I cannot stand it anymore to see the current situation in the repo. :laughing:

I'm already helping a lot like this in the XMPP community, just see my profile. Previously, I contacted the Jitsi developers with this suggestion already via email. However, I haven't receive a response back then.

But yes - I would be happy to join.

Cheers Ed

saghul commented 4 years ago

Sorry Ed, must have missed the message. I’ll invite you to the bug marshalls team!

toby63 commented 4 years ago

@l3d00m Thx for the mention, but I am active in many different communities and projects (not only under this username), so I guess I would only have little time for this.

But if you need help, just ping me again here, and I will see what I can do :slightly_smiling_face:.

By the way, thanks to all volunteers :+1: .

MagicFab commented 4 years ago

@saghul thank you, I can help with forum moderation and tagging/improving messages titles. I am also comfortable with QA (duplicates, triaging, etc.).

luixxiul commented 4 years ago

I'd like tags such as to triage issues:

Since a specific combination of browser and OS often results in a compatibility issue, I expect these tags under OS and Browser would be appreciated.

Question tag would be used to lead a opener to the forum (community.jitsi.org) and close the issue in favor of that.

Priority tags could be used by the development team.

Also QA tags for testing fixes for bugs that needs confirmation among various environments.

Those are my 2 cents 🤞

luixxiul commented 4 years ago

Also I would rename confirmed to bug/confirmed.

Echolon commented 4 years ago

@luixxiul I agree with you but before makeing quick changes to the lables, lets first discuss and agree. I will post some suggestions, too

damencho commented 4 years ago

Not sure this is the rigth place for this, but anyway. @jitsi/bug-marshall When someone creates a PR and says CLA is signed, we need to verify it, which means we(developers) need to check the email coming from docusign and then add the label. So do not add cla-signed just that the creator says so. I say just one PR with that but just wanted to share. Thank you all for the help, that is awesome! Thanks.

luixxiul commented 4 years ago

Apologies- I didn't think those documents had to verified manually.

damencho commented 4 years ago

@luixxiul No worries. I checked everything is fine, we normally check. So do not worry about CLAs we will add those labels if we need to. We are also working on changing and making CLA checking automated, but it will take time if we succeed :).

saghul commented 4 years ago

Sorry I forgot to mention that.

Echolon commented 4 years ago

Sorry Ed, must have missed the message. I’ll invite you to the bug marshalls team!

Absolutely no problem, I know you guys have lots of other work.

Echolon commented 4 years ago

@luixxiul I prefer to keep it a bit more simple. Here are my suggestions:

Additionally:

Eventually:

Last but not least, we should add explanations to each label

saghul commented 4 years ago

Thanks for proposing improvements!

Let's see:

I'd like tags such as to triage issues:

* meet.jit.si

Sounds good.

* OS/Windows

* OS/macOS

* OS/Linux

Not sure about these 3. They'd belong more to the Electron app than here. This repo is more in a web / mobile like scenario.

* OS/Android

If we eliminate the desktop operating sysstems we are left with web and mobile. Then we could rename ios to mobile/ios and android to mobile/android WDYT?

* Browser/Firefox

* Browser/Chromium-based

sounds good!

* Question

Not a fan, we should direct those to the community and close the issue.

* Priority/P1

* Priority/P2

* Priority/P3

So, I feel strongly about this one, not going to lie. And it's a strong NO. The reason why you folks are helping here (and we're increedibly happy you are, hell there are over 100 less issues!) is becaue keeping up with the issue rate is hard. Having to add very sspecific fields like priorities is jusst not going to work. Not to mention it is at odds with our other prioritie (8x8 internal) which are not visible here. This would send the wrong message to the community, so let's skip them for now.

* QA/QA-needed

* QA/QA-done

Not a fan of these either. Again, more process will yield worse results. When Jenkins tests pass a PR is ready, that's the QA.

Thanks a lot for the suggestions!

saghul commented 4 years ago

Also I would rename confirmed to bug/confirmed.

Makes sense, but we need to update the stalebot config file to take that into account. Mind ensing a PR?

saghul commented 4 years ago

I prefer to keep it a bit more simple. Here are my suggestions:

* meet.jit.si  (is there something simpler)?

Nope, that sounds about right!

* Windows

* macOS

* Linux

As I've said earlier, I don't think they belong here.

* Android (existing)

* Browser/Firefox (actually if developers agree I would just use the 'web')

* Browser/Chromium-based (actually if developers agree I would just use 'web')
  Or just Browser only

We have "web" now, but I do see the value in creating a Firefox and Safari label, for example, when there are many issues referencing those. These can be created ad-hoc though.

* Question (for everything in terms of QA, you can always remove labels)

Questions should be redirected to the community and closed.

* Priority

Read my message earlier.

Additionally:

* Bug/Stability

* Security

We have a special security bug flow. Any bug related to security sshoiuld be repporrted through that channel to avoid harming users in case a zero day is found.

* Server (?)

How about "backend" ? Generally these will end up in the videobridge or jicofo repos, but good to label them to keep track.

* UI

Makes sense.

* Audio

* Video (or Videobridge)

We couldd fold those last 2 in "quality" perhaps?

Eventually:

* Microphone

* Camera

We could put those in bug/devices.

Last but not least, we should add explanations to each label

Agreed!

Echolon commented 4 years ago

@sagul I agree with your changes and understand your points. Especially about the priority thing.

One thing to go: Like with the operating systems and browsers, I would create at least one label each ("electron", "browser" (ok, you suggested FF, and Safari already)). That will ensure or at least make it simpler to direct it to the correct repository?

I will create a final draft and once we are happy @saghul can add those.

luixxiul commented 4 years ago 
* OS/Windows

* OS/macOS

* OS/Linux

Not sure about these 3. They'd belong more to the Electron app than here. This repo is more in a web / mobile like scenario.

I understand, no problem with the latter scenario.

Do I understand correctly?

This means: Jitsi Meet on browser on Android (such as Chromebook) -> tagged with Web and Android? This would be the case without deeplinking.

* OS/Android

If we eliminate the desktop operating systems we are left with web and mobile. Then we could rename ios to mobile/ios and android to mobile/android WDYT?

IF I would be correct above, technically there should be these combinations (although they might be just too much complicated):

So I would be inclined to not concat mobile and iOS and Android.

* Question

Not a fan, we should direct those to the community and close the issue.

Basically I thought this label could be used for indicating the fact that belongs to the forums. Adding that label to close the issue. cf: duplicate. 

* Priority/P1

* Priority/P2

* Priority/P3

So, I feel strongly about this one, not going to lie. And it's a strong NO. The reason why you folks are helping here (and we're increedibly happy you are, hell there are over 100 less issues!) is becaue keeping up with the issue rate is hard. Having to add very sspecific fields like priorities is jusst not going to work. Not to mention it is at odds with our other prioritie (8x8 internal) which are not visible here. This would send the wrong message to the community, so let's skip them for now.

No problem at all. Setting priorities includes the whole team's agreement, and can be (and probably already being) done otherwise like Asana.

* QA/QA-needed

* QA/QA-done

Not a fan of these either. Again, more process will yield worse results. When Jenkins tests pass a PR is ready, that's the QA.

I understand this too.

re: https://github.com/jitsi/jitsi-meet/issues/6656#issuecomment-628457614

👍 to

--

Edit:

I would add documentation as well.

Also, in order to indicate the connections with other repos, how about having:

Project should be renamed to another better one. These would be expected to be used when necessary.

I cannot remember well but someone indicated me that applying labels could be automated with a script provided by GitHub.

saghul commented 4 years ago

Do I understand correctly?

* Web: Jitsi Meet on browsers, both self-hosted and `meet.jit.si`

* Mobile: Jitsi Meet on **mobile app**, both on iOS and Android

Correct.

IF I would be correct above, technically there should be these combinations (although they might be just too much complicated):

* `Web` and `Android` (for a case such as Chrome on Chromebook)

* `Web` and `iOS` (for a case such as Safari on iPad)

* `Mobile` and `Android` - mobile app for Android

* `Mobile` and `iOS` - mobile app for iOS

So I would be inclined to not concat mobile and iOS and Android.

You are totally right.

Basically I thought this label could be used for indicating the fact that belongs to the forums. Adding that label to close the issue. cf: duplicate.

Ah, got it. Then yeah, let's have it.

I would add documentation as well.

Oh yeah!

Also, in order to indicate the connections with other repos, how about having:

* Project (?) / Jicofo

* Project / Jitsi-videobridge

* Project / Jibri

* Project / lib-jitsi-meet

Project should be renamed to another better one. These would be expected to be used when necessary.

Makes sense. Let's add those ad-hoc, as the need arises.

I cannot remember well but someone indicated me that applying labels could be automated with a script provided by GitHub.

Yeah, someone mentioned something. But I'm not sure how smart that thing can be. I mean some things are reasonably easy to guess...

luixxiul commented 4 years ago

I cannot remember well but someone indicated me that applying labels could be automated with a script provided by GitHub.

Yeah, someone mentioned something. But I'm not sure how smart that thing can be. I mean some things are reasonably easy to guess...

Please see this as well: https://github.com/jitsi/jitsi-meet/issues/6703

--

Also I have forgot the important stuff, security. It is similar to privacy but there are security issues that are not related with privacy.

saghul commented 4 years ago

Also I have forgot the important stuff, security. It is similar to privacy but there are security issues that are not related with privacy.

Replied above:

We have a special security bug flow. Any bug related to security should be reported through that channel to avoid harming users in case a zero day is found.

We have GH configured to show the security bug flow.

l3d00m commented 4 years ago

I really like the ideas so far and I would generally agree with the resulting labels. One question, is some label like deployment needed? I regularly see issues like #5897 or #6558 where I wouldn't know how to tag them otherwise.

In other repos I often seen some kind of waiting-for-feedback label, which seems to be info:feedback-needed here. I'm used to it as some kind of hint to the stale-bot that those issues can be closed faster if no answer is provided. Does that make sense?

Echolon commented 4 years ago

@l3d00m @saghul @luixxiul

So the remaining tags and their description would be finally if you all agree:

DRAFT:

I suggest you just state your change suggestions and I will update this comment. --> Once you agree, just give your :+1:

And: Let's pick clear colors :red_circle: :green_circle: :yellow_circle: :black_circle: :large_blue_circle:

l3d00m commented 4 years ago

As a quick heads-up, you/we were mentioned in the last jitsi community call at around 6:52. https://youtu.be/Lhihq0Ce9FQ

@echolon Thanks for the list, I'll give some feedback tomorrow.

luixxiul commented 4 years ago

FWIW I sorted them alphabetically:

--

I would add: question to tag the question and close that (See above: https://github.com/jitsi/jitsi-meet/issues/6656#issuecomment-628502376)

@saghul Do you guys need gsoc yet?

saghul commented 4 years ago

Fantastic list! I’ll make the updates tonight!

luixxiul commented 4 years ago

I've forgotten to add api!

saghul commented 4 years ago

I added most of them, left a couple out, let's adjust as we go!

MagicFab commented 4 years ago

It's been a few days now and I've started tagging some issue reports - however I lack other permissions despite being the Jitsi project :

I am not an expert in Github, perhaps I just can't find how to do the above (specially the last one).

I've also requested such permissions regarding forum posts and moderation but still can't do it.

Whenever I have a few minutes I could improve some titles and make posts and issue reports easier to discard or focus on depending on their (improved) titles and tagging.

Is there a non-Slack, non-IRC channel for this type of requests or discussion ? Or forum thread ?

luixxiul commented 4 years ago

Linking /marking duplicates

I thought Duplicate of # should work. -> it's not working.

for example, duplicate of #1.

l3d00m commented 4 years ago

Is there a non-Slack, non-IRC channel for this type of requests or discussion ? Or forum thread ?

I think this would be the best fit: https://github.com/orgs/jitsi/teams/bug-marshalls/discussions

Echolon commented 4 years ago

@saghul

Still, I wonder how to declare general bugs? To qaulity? And general UI issues?

saghul commented 4 years ago

What is a general bug example? UI can fall into web for instance, but I missed to create the UI label, will do.

saghul commented 4 years ago

@MagicFab the permission only applies to this repo for now. Given how well it’s been working so far we may extend it to other like the electron app or the handbook.

Echolon commented 4 years ago

What is a general bug example? UI can fall into web for instance, but I missed to create the UI label, will do.

Just a tag, that we can declare bug, without the need to be 'confirmed'.

saghul commented 4 years ago

And general UI issues?

Added the ui/ux label.

saghul commented 4 years ago

Just a tag, that we can declare bug, without the need to be 'confirmed'.

I worry that most of things would be a bug, except of feature requests I guess.

l3d00m commented 4 years ago

I worry that most of things would be a bug, except of feature requests I guess.

Agreed, having very general tags like this can lead to "over-tagging", so that some issues will have over three tags, which IMO leads to a worse organisation/overview.

saghul commented 4 years ago

Updated the team to have triage access to lib-jitsi-meet, handbook and jitsi-meet-electron.

I think this issue has served its purpose now, let's put it to rest, and continue the good work! We can discuss bug marshaling stuff here: https://github.com/orgs/jitsi/teams/bug-marshalls/discussions

Once again, thanks for all your work so far!

Echolon commented 4 years ago

@saghul just a reminder to put the labels there as well (right?)

saghul commented 4 years ago

Yes, we probably don’t need them all, I’ll try to get to that tomorrow and pick the relevant ones.

luixxiul commented 4 years ago

@luixxiul @MagicFab You have both been invited to the @jitsi/bug-marshalls team. Welcome aboard and thanks for volunteering to help! 🙏

Due to the current situation around myself I have stepped aside from the bug marshal team. I am no longer a part of the volunteer group. I believe that @Echolon, @l3d00m and @MagicFab will keep doing the great work for the community here.

saghul commented 4 years ago

All the best Suguru, and thanks for all your help! ❤️❤️❤️