jitsi / jitsi-meet

Jitsi Meet - Secure, Simple and Scalable Video Conferences that you use as a standalone app or embed in your web application.
https://jitsi.org/meet
Apache License 2.0
23.21k stars 6.74k forks source link

Option to handle our own mic levels when using meet.jit.si. #9290

Closed Blueshawk closed 2 years ago

Blueshawk commented 3 years ago

Is your feature request related to a problem you are facing? Jitsi is adjusting Mic levels at pulse audio until room noise it heard, then system complains about the noise. Linux Artix/runit/cinnamon

Describe the solution you'd like

System Mic volume level stays where you put it. ...as absurd as that sounds. (sarcasm)

Describe alternatives you've considered This is known as AGC or automatic gain control - and it desperately needs to be turned off. the way it is implemented abuses permissions and leaves the system in an unusable state. I'm not calling this a bug because somebody likely spent time implementing it, and I appreciate the effort, but it needs to be an option.

Thank you all for what you do and reading my opinion on this.

Ray

[edited for neatness]

Blueshawk commented 3 years ago

I would add that having a squelch level adjustment would also help and can enter it as a different enhancement if you like.

damencho commented 3 years ago

Not sure you can control that from the browser even if you can, those settings normally are available on the OS level.

damencho commented 3 years ago

Describe alternatives you've considered This is known as AGC or automatic gain control - and it desperately needs to be turned off. the way it is implemented abuses permissions and leaves the system in an unusable state.

You can disable that: https://github.com/jitsi/jitsi-meet/blob/27481f02705241e5753768c18e8b91437fab3b28/config.js#L779

damencho commented 3 years ago

System Mic volume level stays where you put it. ...as absurd as that sounds. (sarcasm)

This is nothing the app controls. This is something between the browser and the OS. So you may search for bugs and issues in the browser's bugtracker for your OS.

Blueshawk commented 3 years ago

Thank you for addressing this so quickly. No other audio chat/record or other system, (mumble - discord, etc.) does this. You can watch the mic level change in the sound manager when using the webapp. Permission must be given to the web app to work.

Okay, I'll check that out.

damencho commented 3 years ago

Do you experience the same in https://appr.tc/?

Blueshawk commented 3 years ago

Librewolf doesn't like something. gray screen. I turned off all the privacy stuff but gray screen with banner. I'll set it up in my rocketchat and see what I get. -->similar results. No ui. Volume stays put though.

Blueshawk commented 3 years ago

As a side note: I found this while researching earlier: #config.disableAudioLevels=true https://jitsi.github.io/handbook/docs/user-guide/user-guide-advanced While this one only disables stat polling, the method seems like it could be used to choose to turn off agc when making a new room at meet.jit.si by adding a command to the list to do so.

I'll be following and can do more as needed. :)

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Blueshawk commented 2 years ago

Describe alternatives you've considered This is known as AGC or automatic gain control - and it desperately needs to be turned off. the way it is implemented abuses permissions and leaves the system in an unusable state.

You can disable that:

https://github.com/jitsi/jitsi-meet/blob/27481f02705241e5753768c18e8b91437fab3b28/config.js#L779

Changing mic levels at system level should be considered a severe security issue. If I turn the mic down it better stay down. Since agc can only be controlled on self run servers, I(and many others) have chosen to pursue a different system. I consider choosing not to fix this, and in fact ignoring it, a sign that Jitsi does not have the open source community or privacy in mind which is a show stopper for many.