search

jitsi / jitsi-videobridge

Jitsi Videobridge is a WebRTC compatible video router or SFU that lets build highly scalable video conferencing infrastructure (i.e., up to hundreds of conferences per server).
https://jitsi.org/jitsi-videobridge
Apache License 2.0
2.91k stars 990 forks source link

XEP-0167: Jingle RTP Sessions 1.2.0 (2020-04-22) defines <rtcp-mux/> is a childElement of <description/> #1267

Open cmeng-git opened 4 years ago

cmeng-git commented 4 years ago

From XEP-0167: Jingle RTP Sessions; the document states that the \ is a childElement of \

However it seems that the childElement \ is always associated with \ extensionElement in all jitsi documentation and in source code implementation.

Is Jisti implementation intentionally differ from XEP-0167 standard?

cmeng-git commented 4 years ago

The Multiplexing RTP Data and Control Packets on a Single Port (April 2010), seems to propose it too to be included in transport https://tools.ietf.org/html/rfc5761 (5.1.3. Interactions with ICE)

bgrozev commented 4 years ago

However it seems that the childElement rtcp-mux is always associated with description

Did you mean 'transport' instead of 'description'?

Our use seems inconsistent. Jicofo adds it in both 'transport' and 'description', while the client only looks for it in 'transport'. I don't know why that is.

Note that jitsi-videobridge does not use XEP-167. It uses COLIBRI, which reuses a lot of XEP-167, but is technically different.

Also note that rtcp-mux is mandatory in WebRTC, and non-mux is no longer supported in jitsi-videobridge, so the presence of the extension is not important (I think it's now safe to remove it, actually).

cmeng-git commented 4 years ago

Note that jitsi-videobridge does not use XEP-167. It uses COLIBRI, which reuses a lot of XEP-167, but is technically different.

Thanks for the clarification. FYI: conversations sends \ as an extension element in \ during the jingle "session-initialize" call setup as per XEP-0167. Jisti also uses jingle protocol during call setup.