search

jitsi / jitsi-videobridge

Jitsi Videobridge is a WebRTC compatible video router or SFU that lets build highly scalable video conferencing infrastructure (i.e., up to hundreds of conferences per server).
https://jitsi.org/jitsi-videobridge
Apache License 2.0
2.91k stars 989 forks source link

out of memory by default for small setups #1575

Open phaabe opened 3 years ago

phaabe commented 3 years ago

Description

With a default configuration of VIDEOBRIDGE_MAX_MEMORY = 3072m small setups with e.g. 2GB RAM will by default experience out of memories.

Current behavior

The standard configuration for VIDEOBRIDGE_MAX_MEMORY in /usr/share/jitsi-videobridge/jvb.sh is 3072m.

Expected Behavior

The standard configuration for VIDEOBRIDGE_MAX_MEMORY in /usr/share/jitsi-videobridge/jvb.sh should be smaller if jitsi videobridge is installed on smaller setups with e.g. 2GB.

Steps to reproduce

(Excuse me this :) ) Install jitsi meet on a server with 2GB memory and invite 30 people to a video conference.

Environment details

I am not sur what solution to propose here. I am sure others(more experienced people) can propose better than me.

damencho commented 3 years ago

You can adjust that setting to fit your needs. You can set VIDEOBRIDGE_MAX_MEMORY for example you can do that in /usr/share/jitsi-videobridge/lib/videobridge.rc

phaabe commented 3 years ago

Agree that it can be adjusted. This is about the default that comes with the installation. I imagine the available memory could be checked and the default setting adjusted at installation. Correct me if this sounds insane :)

damencho commented 3 years ago

No it is not insane. Its just defaults to what we think is common and brings good performance.

bgrozev commented 3 years ago

I think we would accept a PR to adjust it based on available memory.

bgrozev commented 3 years ago

No one would mind if you picked it up :)

On Thu, Oct 14, 2021, 5:16 PM Waldemar Tsiamruk @.***> wrote:

I think we would accept a PR to adjust it based on available memory.

Would that be a "good first issue" for the project? Would you mind if I'll try to pick that up?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jitsi/jitsi-videobridge/issues/1575#issuecomment-943857628, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY5BO5AHYQD6DES4GKQSSTUG5XGJANCNFSM4YDBQ7HQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

wtsiamruk commented 3 years ago

No one would mind if you picked it up :)

As far as i understood so far it's not really code realted and more startup related, so something like shell script should do, right?

What would be other issues that could be considered a "good first issue" but would be more codebase (means java\kotlin) oriented, could you advise please?