feat(config): Make the packet timeline configurable.

jitsi / jitsi-videobridge

Jitsi Videobridge is a WebRTC compatible video router or SFU that lets build highly scalable video conferencing infrastructure (i.e., up to hundreds of conferences per server).

https://jitsi.org/jitsi-videobridge

Apache License 2.0

2.9k stars 988 forks source link

feat(config): Make the packet timeline configurable. #2163

Closed bgrozev closed 3 months ago

JonathanLennox commented 4 months ago

I'm a little concerned what happens to packets that are in flight at the moment the timeline gets turned on.

Maybe restructure it so that PacketInfo.timeline is an EventTimeline? which only gets instantiated if enableTimeline is set, and then everything else checks whether the specific PacketInfo's timeline val is non-null?

bgrozev commented 4 months ago

The timeline is configurable in the config file but once initialized doesn't change (payload verification does, via an http api). I just renamed ENABLE_TIMELINE to enableTimeline because I think that's the usual convention