Remove use-component-socket, cleanup - Githubissues

jitsi / jitsi-videobridge

Jitsi Videobridge is a WebRTC compatible video router or SFU that lets build highly scalable video conferencing infrastructure (i.e., up to hundreds of conferences per server).

https://jitsi.org/jitsi-videobridge

Apache License 2.0

2.9k stars 988 forks source link

Remove use-component-socket, cleanup #2193

Closed bgrozev closed 2 months ago

bgrozev commented 2 months ago

Setting use-component-socket=false has been broken for a long time. We always read/write using the Component's socket: https://github.com/jitsi/jitsi-videobridge/blob/877b6a2f0fdb98f440e094678116b3b090f59533/jvb/src/main/kotlin/org/jitsi/videobridge/transport/ice/IceTransport.kt#L214 https://github.com/jitsi/jitsi-videobridge/blob/877b6a2f0fdb98f440e094678116b3b090f59533/jvb/src/main/kotlin/org/jitsi/videobridge/transport/ice/IceTransport.kt#L245

ref: Move BufferPool setup to Main.
ref: Remove the use-component-socket option.
log: Remove endpoint ID from IceMediaStream name.