search

jitsi / jitsi-xmpp-extensions

Common library holding all jitsi specific smack xmpp extensions.
Apache License 2.0
15 stars 51 forks source link

Switched from StringUtils to google Strings and added right angle bra… #6

Closed GNUDimarik closed 5 years ago

GNUDimarik commented 5 years ago

…cket for file element for thumbnails

By documentation https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/StringUtils.html#isEmpty-java.lang.CharSequence-

isEmpty returns true for null too. public static boolean isEmpty(CharSequence cs) Checks if a CharSequence is empty ("") or null.

StringUtils.isEmpty(null) = true StringUtils.isEmpty("") = true StringUtils.isEmpty(" ") = false StringUtils.isEmpty("bob") = false StringUtils.isEmpty(" bob ") = false

GNUDimarik commented 5 years ago

@ibauersachs is 3.9 version ok? Or should I change it to 3.3?

GNUDimarik commented 5 years ago

@ibauersachs please check when you have a chance. If you are right with version 3.9 I'll use it in Jitsi too.

ibauersachs commented 5 years ago

Split these changes. 1 PR (this one) for the xml-right-angle-bracket. Another PR to replace ALL StringUtils.something in this project with Apache Commons 3.9.

And 3.9 in Jitsi Desktop is fine - but beware: I cannot accept a PR with a binary in it. So I'd strongly suggest you'd go for the build system first. Either create POMs for all everything that needs to be built as a jar OR find something that you can include in the Ant to reference Maven coordinates (or maybe a combination of both).

GNUDimarik commented 5 years ago

@ibauersachs I'll close this one and replace everything in whole library to apache lang3 and make new one soon