search

jitsi / js-utils

Utilities for Jitsi JS projects
Apache License 2.0
32 stars 60 forks source link

Update Electron userAgent detection #30

Closed zeha closed 2 years ago

zeha commented 4 years ago

Fixes #29

zeha commented 4 years ago

@emcho @saghul could you review this, please?

saghul commented 4 years ago

ccan you please share an example of the old and the new UA strings?

zeha commented 4 years ago

ccan you please share an example of the old and the new UA strings?

Sorry, I don't have the old UA anymore.

New UA was mentioned in the issue:

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.163 Safari/537.36 Ferdi/5.5.0 (Electron 8.2.3)
saghul commented 4 years ago

I’m not seeing this problem with Jitsi Meet electron. Any chance you have customized the UA in your app?

zeha commented 4 years ago

As said, I'm using Ferdi.app, which just happens to be an Electron app. It still shouldn't crash :)

DanielMcAssey commented 3 years ago

I believe the newer Electron versions (10+) changed the format of the UA, its not seperated by a slash anymore. My PR #33 marks it as optional

saghul commented 2 years ago

Fixed in https://github.com/jitsi/js-utils/pull/33