search

jitsi / js-utils

Utilities for Jitsi JS projects
Apache License 2.0
33 stars 60 forks source link

feat: add random utils and meeting name generator #7

Closed virtuacoplenny closed 5 years ago

paweldomas commented 5 years ago

Is this the exact same logic that we used to have in jitsi-meet ?

virtuacoplenny commented 5 years ago

The logic has been pulled out from jitsi-meet and into js-utils so it can be reused in jitsi-meet-spot.

paweldomas commented 5 years ago

Wasn't there another set of words used in spot ? I think I liked it more for spot's purpose

virtuacoplenny commented 5 years ago

There was another set of words but I was explicitly told to copy/paste the jitsi-meet implementation. I was told the implementation of random meeting names in jitsi-meet has some math behind it to hit some threshold of possible meeting combinations.

damencho commented 5 years ago

There was one more set in jidesha when we were using google cloud transcribe to convert speech to text for a room, and there was a server side limitation of 500 words, so we were limiting the dictionary there, but this is already in the history and should not be used.