search

jitsi / lib-jitsi-meet

A low-level JS video API that allows adding a completely custom video experience to web apps.
Apache License 2.0
1.34k stars 1.12k forks source link

feat: disableScreenshareSimulcast #1584

Open psi-4ward opened 3 years ago

psi-4ward commented 3 years ago

We have a use case where it makes sense to have simulcast for Webcams enabled but not for screenshares. Are you open for a PR with an config option to disable simulcast for screenshares and setting it's bitrate? Like a follow up for unclear capScreenshareBitrate?

    desktopSharingFrameRate: {
         max: 30
    },
    desktopShareBitrate: 2e6,
    disableSimulcastScreenshare: true,
jallamsetty1 commented 3 years ago

Yes, we would be open to a PR that provides the ability to control simulcast and bitrate for screenshare. capScreenshareBitrate was introduced as part of A/B testing effort when we started seeing issues with simulcast screenshare and it didn't make sense to continue using it.

psi-4ward commented 3 years ago

Nice.

Do you think there are any reasons to use simulcast for screenshare but not for video?

jallamsetty1 commented 3 years ago

Nice.

Do you think there are any reasons to use simulcast for screenshare but not for video?

Nope.