search

jitsi / lib-jitsi-meet

A low-level JS video API that allows adding a completely custom video experience to web apps.
Apache License 2.0
1.33k stars 1.11k forks source link

Cant add second audio stream (Desktop Audio Share) #2205

Open DanielMcAssey opened 1 year ago

DanielMcAssey commented 1 year ago

This Issue tracker is only for reporting bugs and tracking code related issues.

Before posting, please make sure you check community.jitsi.org to see if the same or similar bugs have already been discussed. General questions, installation help, and feature requests can also be posted to community.jitsi.org.

Description

Currently you cant add a second audio stream, so sharing desktop audio is broken if you are also using a microphone. With multi-stream this limitation is not required.

Current behavior

You cant add a second audio stream.

Expected Behavior

Ability to add a second audio stream

Possible Solution

Add the ability to add a second audio stream

Steps to reproduce

  1. Join a session
  2. Share desktop with audio

    Environment details

    Custom client

damencho commented 1 year ago

Please, when you have questions or problems use the community forum before opening new issues, thank you.

Do you reproduce this on meet.jit.si?

DanielMcAssey commented 1 year ago

Understood, this is more a limitation of the library as seen here: https://github.com/jitsi/lib-jitsi-meet/blob/master/JitsiConference.js#L1145 probably from a leftover before multi-stream.

I did not reproduce this on meet.jit.si. That being said, since multi-stream this limitation is probably not needed any more, I raised this more as a query/feature/improvement rather than a problem with meet.jit.si

damencho commented 1 year ago

leftover before multi-stream.

Yep, there is no longer no multi-stream mode.

I did not reproduce this on meet.jit.si. That being said, since multi-stream this limitation is probably not needed any more, I raised this more as a query/feature/improvement rather than a problem with meet.jit.si

I was not asking about meet.jit.si to find out whether its a problem there, as you said a custom client, it was more to compare custom client and jitsi-meet. There are some effects that are applied in jitsi-meet, and (I'm not 100% sure where the code lives) one of them is audio mixing of local audio and desktop audio.

DanielMcAssey commented 1 year ago

Sorry why was this closed? Whats the best way to request an improvement?

With JitsiMeet, its the AudioMixerEffect, however with multi-stream this really isn't needed and with a few changes to this library, the effect can be removed and impact on CPU can be reduced.

damencho commented 1 year ago

Its not only in lib-jitsi-meet, changes are needed in jicofo and jvb.

DanielMcAssey commented 1 year ago

Ah okay! I may have a look over the next few weeks, see if I can list all the changes needed. (I may attempt some if I get some time). Thanks for re-opening

saghul commented 1 year ago

Out of curiosity, why would you want separate audio tracks and not to send a mixed one?

DanielMcAssey commented 1 year ago

It would be great to be able to programmatically listen in to either the desktop audio or the participants microphone, or any other audio input for that matter

maxired commented 1 year ago

Out of curiosity, why would you want separate audio tracks and not to send a mixed one?

@saghul I personally would like client to be able to adjust volume for each tracks