jitsi / lib-jitsi-meet

A low-level JS video API that allows adding a completely custom video experience to web apps.
Apache License 2.0
1.34k stars 1.11k forks source link

Using multi-stream, I cannot add a video track after one was removed. #2218

Open maxired opened 1 year ago

maxired commented 1 year ago

Description

Using multi-stream, I cannot add a track after one was removed.

As a user creating a camera track, then a screen share track, then removing my camera track, then recreating one

Current behavior

Both tracks cannot be seen

Expected Behavior

A remote participant can see both tracks

Possible Solution

I think the source name in https://github.com/fres-co/lib-jitsi-meet/blob/d81a1d8b9c42b0b0bb7bde6f8e4432ae051ad08c/JitsiConference.js#L1138 is an issue. from what I understand in my scenario it creates a first camera track with *-v0, then screen share with *-v1. But then when the camera track is removed then another one is recreated, it will also be named v1

Steps to reproduce

Environment details

lib jitsi corresponding to version jitsi meet 8252

maxired commented 1 year ago

Also, this might be related to https://github.com/jitsi/lib-jitsi-meet/blob/931ca368b79004a103451dde9d6f89dbe1415e2c/modules/RTC/TraceablePeerConnection.js#L1243

saghul commented 1 year ago

Ping @jallamsetty1