search

jitsi / lib-jitsi-meet

A low-level JS video API that allows adding a completely custom video experience to web apps.
Apache License 2.0
1.33k stars 1.11k forks source link

[rnsdk] External api module not added for SDK #2527

Open Anfieldd opened 2 months ago

Anfieldd commented 2 months ago

Hi guys! With one of the last stables notifyTranscriptionChunkReceived function was added. export const notifyTranscriptionChunkReceived = (transcriptMessageID: string, language: string, participant: Object, text: any, _store?: any) => sendEvent( _store, TRANSCRIPTION_CHUNK_RECEIVED, { messageID: transcriptMessageID, language, participant, text });

This function uses the ExternalAPI native module which wasn't added to the prepare_sdk script and my subtitles didn't work. I fixed it for ios by adding this code to the prepare_sdk script fs.copyFileSync( ${iosSrcPath}/ExternalAPI.m, ${iosDestPath}/ExternalAPI.m ); fs.copyFileSync( ${iosSrcPath}/ExternalAPI.h, ${iosDestPath}/ExternalAPI.h ); fs.copyFileSync( ${androidSourcePath}/ExternalAPIModule.java, ${androidTargetPath}/ExternalAPIModule.java ); And in react-native-sdk/android/src/main/java/org/jitsi/meet/sdk/JitsiMeetReactNativePackage.java new ExternalAPIModule(reactContext), But for android I have a lot of errors during the build in ExternalAPIModule.java file.

Screenshot 2024-05-16 at 20 14 14

Could you help me with this or maybe you can update the prepare_sdk script for last stables? Thanks!

saghul commented 2 months ago

The rnsdk doesn't use that ExternalAPI because that one is for the native implementation. That said, we should be exposing this event on the rnsdk too. @Calinteodor PTAL when you get a chance.