fix(chat-features): Add messageId and change id to participantId - Githubissues

jitsi / lib-jitsi-meet

A low-level JS video API that allows adding a completely custom video experience to web apps.

Apache License 2.0

1.34k stars 1.11k forks source link

fix(chat-features): Add messageId and change id to participantId #2548

Closed he-patrick closed 3 months ago

he-patrick commented 4 months ago

messageId needs to be added to be able to attach reactions to specific messages
participantId indicates that it is the participant's id rather than the message's id

jitsi-jenkins commented 4 months ago

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

damencho commented 3 months ago

@damencho Can you PTAL too? Context: GSoC project, reactions, etc hey need the original message ID.

According to RFC:

For <message/> and <presence/> stanzas, it is RECOMMENDED for the
   originating entity to include an 'id' attribute; for <iq/> stanzas,
   it is REQUIRED.

it is possible that there is no id, is that a problem?

saghul commented 3 months ago

Ugh, good point! How about we generate an uuid v4 in that case?

he-patrick commented 3 months ago

I added the uuid v4 generation on JM.

saghul commented 3 months ago

I added the uuid v4 generation on JM.

Add it here please, so the applications don't need to worry about that and can assume it's there.

saghul commented 3 months ago

Code looks good but you need to fix the import order. Run "npm run lint" to see exactly what's wrong, or check the CI step output.

damencho commented 3 months ago

jenkins test this please

saghul commented 3 months ago

Looks like there are some typing errors you need to tackle in the JM PR:

+ cd jitsi-meet
+ PID_MAKE=585237
+ wait 585237
+ make
NODE_OPTIONS=--max-old-space-size=8192 \
./node_modules/.bin/webpack
[BABEL] Note: The code generator has deoptimised the styling of /home/jenkins/workspace/pr-test/jitsi-meet/node_modules/@vladmandic/human/dist/human.esm.js as it exceeds the max of 500KB.
[BABEL] Note: The code generator has deoptimised the styling of /home/jenkins/workspace/pr-test/jitsi-meet/node_modules/lodash/lodash.js as it exceeds the max of 500KB.
[BABEL] Note: The code generator has deoptimised the styling of /home/jenkins/workspace/pr-test/jitsi-meet/node_modules/@jitsi/excalidraw/dist/excalidraw.production.min.js as it exceeds the max of 500KB.
[BABEL] Note: The code generator has deoptimised the styling of /home/jenkins/workspace/pr-test/jitsi-meet/node_modules/lodash/lodash.js as it exceeds the max of 500KB.
[BABEL] Note: The code generator has deoptimised the styling of /home/jenkins/workspace/pr-test/jitsi-meet/node_modules/zxcvbn/lib/frequency_lists.js as it exceeds the max of 500KB.
assets by status 4.46 MiB [cached] 1 asset
orphan modules 5.45 MiB [orphan] 1793 modules
runtime modules 2.77 KiB 10 modules
cacheable modules 9.76 MiB
  modules by path ./node_modules/ 4.58 MiB
    javascript modules 4.52 MiB 325 modules
    json modules 67.1 KiB
      modules by path ./node_modules/@giphy/ 3.82 KiB 3 modules
      + 3 modules
  modules by path ./react/features/ 59.1 KiB
    modules by path ./react/features/base/ 42 bytes 2 modules
    modules by path ./react/features/stream-effects/ 57.5 KiB 2 modules
    ./react/features/screenshot-capture/createImageBitmap.js 703 bytes [built] [code generated]
    ./react/features/face-landmarks/createImageBitmap.ts 906 bytes [built] [code generated]
  + 8 modules

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts
./react/features/breakout-rooms/middleware.ts 86:91-93
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts(86,92)
      TS2339: Property 'id' does not exist on type 'IMessage'.
 @ ./react/features/app/middlewares.any.ts 22:0-38
 @ ./react/features/app/middlewares.web.ts 25:0-27
 @ ./react/features/app/components/App.web.tsx 9:0-24
 @ ./react/index.web.js 3:0-56 50:7-10
 @ ./app.js 40:0-17

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts
./react/features/breakout-rooms/middleware.ts 91:92-94
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts(91,93)
      TS2339: Property 'id' does not exist on type 'IMessage'.
 @ ./react/features/app/middlewares.any.ts 22:0-38
 @ ./react/features/app/middlewares.web.ts 25:0-27
 @ ./react/features/app/components/App.web.tsx 9:0-24
 @ ./react/index.web.js 3:0-56 50:7-10
 @ ./app.js 40:0-17

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/functions.ts
./react/features/chat/functions.ts 175:58-60
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/functions.ts(175,59)
      TS2339: Property 'id' does not exist on type 'IMessage'.
 @ ./react/features/chat/middleware.ts 26:0-45 47:26-40
 @ ./react/features/lobby/actions.any.ts 6:0-64 358:32-58
 @ ./conference.js 37:0-86 1231:29-61
 @ ./app.js 15:0-38 29:2-12

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts
./react/features/chat/components/AbstractMessageContainer.ts 39:24-26
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts(39,25)
      TS2339: Property 'id' does not exist on type 'IMessage'.
 @ ./react/features/chat/components/web/MessageContainer.tsx 5:0-67 13:46-70
 @ ./react/features/chat/components/web/Chat.tsx 16:0-50 127:36-52
 @ ./react/features/conference/components/web/Conference.tsx 11:0-53 125:32-36
 @ ./react/features/app/getRouteToRender.web.ts 9:0-65 76:30-40
 @ ./react/features/app/middleware.ts 10:0-55 126:4-21
 @ ./react/features/app/middlewares.any.ts 57:0-22
 @ ./react/features/app/middlewares.web.ts 25:0-27
 @ ./react/features/app/components/App.web.tsx 9:0-24
 @ ./react/index.web.js 3:0-56 50:7-10
 @ ./app.js 40:0-17

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts
./react/features/chat/components/AbstractMessageContainer.ts 45:52-54
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts(45,53)
      TS2339: Property 'id' does not exist on type 'IMessage'.
 @ ./react/features/chat/components/web/MessageContainer.tsx 5:0-67 13:46-70
 @ ./react/features/chat/components/web/Chat.tsx 16:0-50 127:36-52
 @ ./react/features/conference/components/web/Conference.tsx 11:0-53 125:32-36
 @ ./react/features/app/getRouteToRender.web.ts 9:0-65 76:30-40
 @ ./react/features/app/middleware.ts 10:0-55 126:4-21
 @ ./react/features/app/middlewares.any.ts 57:0-22
 @ ./react/features/app/middlewares.web.ts 25:0-27
 @ ./react/features/app/components/App.web.tsx 9:0-24
 @ ./react/index.web.js 3:0-56 50:7-10
 @ ./app.js 40:0-17

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessage.tsx
./react/features/chat/components/web/ChatMessage.tsx 200:62-64
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessage.tsx(200,63)
      TS2339: Property 'id' does not exist on type 'IMessage'.
 @ ./react/features/chat/components/web/ChatMessageGroup.tsx 5:0-40 41:159-170
 @ ./react/features/chat/components/web/MessageContainer.tsx 6:0-50 49:40-56
 @ ./react/features/chat/components/web/Chat.tsx 16:0-50 127:36-52
 @ ./react/features/conference/components/web/Conference.tsx 11:0-53 125:32-36
 @ ./react/features/app/getRouteToRender.web.ts 9:0-65 76:30-40
 @ ./react/features/app/middleware.ts 10:0-55 126:4-21
 @ ./react/features/app/middlewares.any.ts 57:0-22
 @ ./react/features/app/middlewares.web.ts 25:0-27
 @ ./react/features/app/components/App.web.tsx 9:0-24
 @ ./react/index.web.js 3:0-56 50:7-10
 @ ./app.js 40:0-17

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessageGroup.tsx
./react/features/chat/components/web/ChatMessageGroup.tsx 69:46-48
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessageGroup.tsx(69,47)
      TS2339: Property 'id' does not exist on type 'IMessage'.
 @ ./react/features/chat/components/web/MessageContainer.tsx 6:0-50 49:40-56
 @ ./react/features/chat/components/web/Chat.tsx 16:0-50 127:36-52
 @ ./react/features/conference/components/web/Conference.tsx 11:0-53 125:32-36
 @ ./react/features/app/getRouteToRender.web.ts 9:0-65 76:30-40
 @ ./react/features/app/middleware.ts 10:0-55 126:4-21
 @ ./react/features/app/middlewares.any.ts 57:0-22
 @ ./react/features/app/middlewares.web.ts 25:0-27
 @ ./react/features/app/components/App.web.tsx 9:0-24
 @ ./react/index.web.js 3:0-56 50:7-10
 @ ./app.js 40:0-17

7 errors have detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

webpack 5.76.0 compiled with 7 errors in 226806 ms

assets by status 382 KiB [cached] 1 asset
orphan modules 599 KiB [orphan] 345 modules
runtime modules 2.37 KiB 7 modules
cacheable modules 1.13 MiB
  modules by path ./node_modules/react/ 8.91 KiB
    ./node_modules/react/index.js 189 bytes [built] [code generated]
    ./node_modules/react/cjs/react.production.min.js 8.73 KiB [built] [code generated]
  modules by path ./node_modules/react-dom/ 193 KiB
    ./node_modules/react-dom/index.js 1.32 KiB [built] [code generated]
    ./node_modules/react-dom/cjs/react-dom.production.min.js 192 KiB [built] [code generated]
  modules by path ./node_modules/scheduler/ 5.91 KiB
    ./node_modules/scheduler/index.js 197 bytes [built] [code generated]
    ./node_modules/scheduler/cjs/scheduler.production.min.js 5.72 KiB [built] [code generated]
  ./react/features/always-on-top/index.tsx + 204 modules 358 KiB [built] [code generated]
  ./node_modules/grapheme-splitter/index.js 120 KiB [built] [code generated]
  ./node_modules/lodash/lodash.js 469 KiB [built] [code generated]

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts
86:91-93
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts(86,92)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts
91:92-94
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts(91,93)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/functions.ts
175:58-60
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/functions.ts(175,59)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts
39:24-26
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts(39,25)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts
45:52-54
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts(45,53)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessage.tsx
200:62-64
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessage.tsx(200,63)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessageGroup.tsx
69:46-48
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessageGroup.tsx(69,47)
      TS2339: Property 'id' does not exist on type 'IMessage'.

7 errors have detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

webpack 5.76.0 compiled with 7 errors in 172911 ms

assets by status 2.17 KiB [cached] 1 asset
orphan modules 6.95 KiB [orphan] 2 modules
./react/features/analytics/handlers/GoogleAnalyticsHandler.ts + 2 modules 11.7 KiB [built] [code generated]

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts
86:91-93
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts(86,92)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts
91:92-94
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts(91,93)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/functions.ts
175:58-60
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/functions.ts(175,59)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts
39:24-26
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts(39,25)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts
45:52-54
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts(45,53)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessage.tsx
200:62-64
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessage.tsx(200,63)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessageGroup.tsx
69:46-48
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessageGroup.tsx(69,47)
      TS2339: Property 'id' does not exist on type 'IMessage'.

7 errors have detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

webpack 5.76.0 compiled with 7 errors in 53818 ms

asset close3.min.js 0 bytes [emitted] [minimized] (name: close3)
./static/close3.js 1 bytes [built] [code generated]
webpack 5.76.0 compiled successfully in 26629 ms

assets by status 37.3 KiB [cached] 1 asset
orphan modules 52.6 KiB [orphan] 14 modules
runtime modules 663 bytes 3 modules
cacheable modules 136 KiB
  modules by path ./node_modules/ 38.7 KiB
    modules by path ./node_modules/@jitsi/ 20.9 KiB
      ./node_modules/@jitsi/logger/lib/index.js 3.98 KiB [built] [code generated]
      + 2 modules
    modules by path ./node_modules/@braintree/sanitize-url/dist/*.js 1.9 KiB
      ./node_modules/@braintree/sanitize-url/dist/index.js 1.25 KiB [built] [code generated]
      ./node_modules/@braintree/sanitize-url/dist/constants.js 667 bytes [built] [code generated]
    ./node_modules/events/events.js 13.9 KiB [built] [code generated]
    ./node_modules/@hapi/bourne/lib/index.js 2.02 KiB [built] [code generated]
  modules by path ./modules/API/external/*.js 97.8 KiB
    ./modules/API/external/index.js 171 bytes [built] [code generated]
    ./modules/API/external/external_api.js + 13 modules 97.6 KiB [built] [code generated]

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts
86:91-93
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts(86,92)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts
91:92-94
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts(91,93)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/functions.ts
175:58-60
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/functions.ts(175,59)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts
39:24-26
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts(39,25)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts
45:52-54
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts(45,53)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessage.tsx
200:62-64
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessage.tsx(200,63)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessageGroup.tsx
69:46-48
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessageGroup.tsx(69,47)
      TS2339: Property 'id' does not exist on type 'IMessage'.

7 errors have detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

webpack 5.76.0 compiled with 7 errors in 102606 ms

assets by status 1.81 MiB [cached] 1 asset
orphan modules 3.01 MiB [orphan] 508 modules
runtime modules 914 bytes 5 modules
cacheable modules 2.69 MiB
  modules by path ./ 2.69 MiB
    modules by path ./node_modules/@tensorflow/tfjs-backend-wasm/ 137 KiB
      ./node_modules/@tensorflow/tfjs-backend-wasm/wasm-out/tfjs-backend-wasm-threaded-simd.js 94.9 KiB [built] [code generated]
      ./node_modules/@tensorflow/tfjs-backend-wasm/wasm-out/tfjs-backend-wasm.js 42.2 KiB [built] [code generated]
    ./react/features/face-landmarks/faceLandmarksWorker.ts + 293 modules 2.52 MiB [built] [code generated]
    ./node_modules/long/src/long.js 35.9 KiB [built] [code generated]
  + 7 modules

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts
86:91-93
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts(86,92)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts
91:92-94
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts(91,93)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/functions.ts
175:58-60
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/functions.ts(175,59)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts
39:24-26
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts(39,25)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts
45:52-54
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts(45,53)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessage.tsx
200:62-64
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessage.tsx(200,63)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessageGroup.tsx
69:46-48
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessageGroup.tsx(69,47)
      TS2339: Property 'id' does not exist on type 'IMessage'.

7 errors have detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

webpack 5.76.0 compiled with 7 errors in 153327 ms

assets by status 154 KiB [cached] 1 asset
orphan modules 181 KiB [orphan] 5 modules
./react/features/stream-effects/noise-suppression/NoiseSuppressorWorklet.ts + 5 modules 189 KiB [built] [code generated]

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts
86:91-93
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts(86,92)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts
91:92-94
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts(91,93)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/functions.ts
175:58-60
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/functions.ts(175,59)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts
39:24-26
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts(39,25)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts
45:52-54
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts(45,53)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessage.tsx
200:62-64
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessage.tsx(200,63)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessageGroup.tsx
69:46-48
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessageGroup.tsx(69,47)
      TS2339: Property 'id' does not exist on type 'IMessage'.

7 errors have detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

webpack 5.76.0 compiled with 7 errors in 89022 ms

assets by status 3.75 KiB [cached] 1 asset
runtime modules 663 bytes 3 modules
orphan modules 1000 bytes [orphan] 1 module
cacheable modules 11.5 KiB
  ./react/features/screenshot-capture/worker.ts + 1 modules 3.7 KiB [built] [code generated]
  ./node_modules/pixelmatch/index.js 7.79 KiB [built] [code generated]

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts
86:91-93
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts(86,92)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts
91:92-94
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/breakout-rooms/middleware.ts(91,93)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/functions.ts
175:58-60
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/functions.ts(175,59)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts
39:24-26
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts(39,25)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts
45:52-54
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/AbstractMessageContainer.ts(45,53)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessage.tsx
200:62-64
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessage.tsx(200,63)
      TS2339: Property 'id' does not exist on type 'IMessage'.

ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessageGroup.tsx
69:46-48
[tsl] ERROR in /home/jenkins/workspace/pr-test/jitsi-meet/react/features/chat/components/web/ChatMessageGroup.tsx(69,47)
      TS2339: Property 'id' does not exist on type 'IMessage'.

7 errors have detailed information that is not shown.
Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.

webpack 5.76.0 compiled with 7 errors in 65430 ms
make: *** [Makefile:30: compile] Error 1

he-patrick commented 3 months ago

For the parameters, lint says to put them in ascending order. Should I do that or did we want to keep the custom order? And if so do I add eslint-disable sort-vars?

saghul commented 3 months ago

For the parameters, lint says to put them in ascending order. Should I do that or did we want to keep the custom order? And if so do I add eslint-disable sort-vars?

You can sort them since they are really an object, not plain parameters where the order matters.

saghul commented 3 months ago

Jenkins please test this please.

saghul commented 3 months ago

Unrelated test failure, landing.

saghul commented 3 months ago

Great work @he-patrick ! 🚀

damencho commented 3 months ago

It may be related, as the error is in IFrameAPICommandsTest. testCommandSendChatMessage ...