search

jitsi / lib-jitsi-meet

A low-level JS video API that allows adding a completely custom video experience to web apps.
Apache License 2.0
1.34k stars 1.11k forks source link

feat(statistics) remove AudioOutputProblemDetector #2551

Closed saghul closed 3 months ago

saghul commented 3 months ago

It has been broken for over 3 years now, since https://github.com/jitsi/lib-jitsi-meet/commit/ca325f5ef93f853d12ad39ceb40b9bac6b05a56c#diff-9e19da30f465ca5665ac3d7ca1aa03d0498aed1be0cb2d7eeb27684a2636da77

Ever since that change, the "audioLevelReportHistory" property is not populated, so it justs acts on nothing an generates bogus log lines such as:

[modules/statistics/AudioOutputProblemDetector.js] A potential problem is detected with the audio output for participant b5fb30bc, local audio levels: [null,null], remote audio levels: undefined

Since nobody seems to have noticed in 3 years it's safe to assume we don't need this at all, so it gets the axe treatment.

jallamsetty1 commented 3 months ago

Good catch @saghul! We have moved away from getting audio levels from getStats to using getSynchronizationSources on the receiver since getStats is very expensive and we do that for the only the top 5 active speakers. We can fix this by populating audioLevelReportHistory for the top 5 active speakers but since its going to be only for a subset of remote SSRCs it doesn't help much.