fix(quality) Do not set b:AS line in SDP for SVC codecs when codec selection API is used.

jitsi / lib-jitsi-meet

A low-level JS video API that allows adding a completely custom video experience to web apps.

Apache License 2.0

1.34k stars 1.11k forks source link

fix(quality) Do not set b:AS line in SDP for SVC codecs when codec selection API is used. #2567

Closed jallamsetty1 closed 2 months ago

jallamsetty1 commented 2 months ago

This was needed in older versions since the browser didn't apply maxBitrates from RTCRtpEncoderParameters on the encoder. In the newer versions this seems to be no longer the case. Also, when the codec selection API is used, we no longer renegotiate locally so if we switched codec from AV1->VP9-VP9, the AV1 bitrate setting in the SDP will still be effective resulting in a lower send resolution because of b/w limitation.