search

jitsi / libjitsi

Advanced Java media library for secure real-time audio/video communication.
Apache License 2.0
628 stars 281 forks source link

Move SRTP core implementation to jitsi-srtp package. #487

Closed JonathanLennox closed 4 years ago

JonathanLennox commented 5 years ago

Adapt for API differences.

ibauersachs commented 5 years ago

AFAIK the Jitsi Desktop never used the OpenSSL functions.

ibauersachs commented 5 years ago

jitsi-srtp seems to be missing OSGi exports, so it won't work with Jitsi Desktop (and maybe Jigasi).

bgrozev commented 5 years ago

jitsi-srtp seems to be missing OSGi exports, so it won't work with Jitsi Desktop (and maybe Jigasi).

Oh yeah, I guess this is what Damian ran into, because I see the maven tests fallback to another implementation on mac.

damencho commented 5 years ago

So, the previous time I tested jigasi apparently it was not tested with correct jitsi-utils version and everything was failing. Now with the correct versions, I tested this PR and it was working fine from a Mac machine.

JonathanLennox commented 5 years ago

@ibauersachs: Can you take a look at https://github.com/jitsi/jitsi-srtp/pull/3 and see if would fix the problem for Jitsi Desktop?

JonathanLennox commented 5 years ago

And yes, only Linux ever used OpenSSL code previously for srtp.

jitsi-srtp only includes OpenSSL code for 64-bit Linux, and links with OpenSSL 1.1.x, so 32-bit linux and older distros (older than Ubuntu 18.04 or Debian stretch) will now also fall back to the Java crypto implementations.

Neustradamus commented 4 years ago

Any news on it?

Neustradamus commented 4 years ago

@ibauersachs: Thanks!