search

jitsi / libjitsi

Advanced Java media library for secure real-time audio/video communication.
Apache License 2.0
628 stars 281 forks source link

Switch AST to default to true. #488

Closed bgrozev closed 5 years ago

bgrozev commented 5 years ago

This has been turned on in the bridge for a long time, and I'd like to remove the code which enables it: https://github.com/jitsi/jitsi-videobridge/blob/master/src/main/java/org/jitsi/videobridge/osgi/JvbBundleConfig.java#L151

bbaldino commented 5 years ago

lgtm, but, is it worth having this parameter at all if it one of the options doesn't work (well)?

bgrozev commented 5 years ago

Removing this was satisfying :)

bbaldino commented 5 years ago

lgtm but looks like the bridge was checking that param too and will need a change:

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /home/jenkins/jitsi-videobridge/src/main/java/org/jitsi/videobridge/osgi/JvbBundleConfig.java:[151,51] cannot find symbol
  symbol:   variable ENABLE_AST_RBE_PNAME
  location: class org.jitsi.impl.neomedia.rtp.remotebitrateestimator.RemoteBitrateEstimatorWrapper
[INFO] 1 error
bgrozev commented 5 years ago

This is removed in jitsi/jitsi-videobridge#901